Skip to content

feat(worbench-setup): make plugin development self-contained #13

Merged
SlimDeluxe merged 46 commits intoDataLinx:mainfrom
KilianTrunk:feat/workbench-setup
Sep 4, 2025
Merged

feat(worbench-setup): make plugin development self-contained #13
SlimDeluxe merged 46 commits intoDataLinx:mainfrom
KilianTrunk:feat/workbench-setup

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, however please see comments below.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.14%. Comparing base (0794260) to head (1e2758a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #13   +/-   ##
=========================================
  Coverage     82.14%   82.14%           
  Complexity      160      160           
=========================================
  Files            25       25           
  Lines          1008     1008           
=========================================
  Hits            828      828           
  Misses          180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KilianTrunk KilianTrunk force-pushed the feat/workbench-setup branch from 3245191 to 9de4466 Compare August 16, 2025 09:05
@KilianTrunk KilianTrunk requested a review from SlimDeluxe August 16, 2025 09:19
@KilianTrunk
Copy link
Contributor Author

@SlimDeluxe try running it, let me know how it goes on your end, I've been getting some issues locally

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some quick fixes I found were necessary.
Moreover:

  1. The workbench/public dir is missing. You had it in .gitignore. Please set it up.
  2. It appears you made a mistake and committed a new file, lando.yml with only 1 added line compared to lando.dist.yml.
  3. There were some migrations problems. I tried fixing it, but the tests fail due to a 500 error - maybe because of the missing public dir. Please see about it.

@KilianTrunk
Copy link
Contributor Author

🤠🔫

We need to add the /app prefix because that's the path where our project folder
is mounted inside the container.
@KilianTrunk KilianTrunk requested a review from SlimDeluxe August 21, 2025 11:53
@SlimDeluxe
Copy link
Member

Sorry, still the permissions table causing trouble. I cloned the repo into a new local dir to start from scratch and after running lando start this is what happens.

image

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check PR comment

@SlimDeluxe
Copy link
Member

SlimDeluxe commented Aug 28, 2025

When running tests locally, they now pass. But in CI, as you see, they're broken 🤢
It's strange that after your last commit they passed, but then I push a small non-related fix (lando is not used in CI) and they fail. The only thing that changed is the author, so please try to push a dummy file to trigger a new run. If I'm correct, the tests will pass after your commit, as crazy as it sounds.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, merging 👍

<server name="CACHE_STORE" value="array"/>
<server name="DB_CONNECTION" value="sqlite"/>
<server name="DB_DATABASE" value=":memory:"/>
<server name="DB_DATABASE" value="workbench/database/database.sqlite"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about why you switched to a file instead of :memory:, there must have been a reason? To my surprise both are equally fast (/slow).

@SlimDeluxe SlimDeluxe merged commit 421264d into DataLinx:main Sep 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants