feat(worbench-setup): make plugin development self-contained #13
feat(worbench-setup): make plugin development self-contained #13SlimDeluxe merged 46 commits intoDataLinx:mainfrom
Conversation
SlimDeluxe
left a comment
There was a problem hiding this comment.
This is much better, however please see comments below.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 82.14% 82.14%
Complexity 160 160
=========================================
Files 25 25
Lines 1008 1008
=========================================
Hits 828 828
Misses 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3245191 to
9de4466
Compare
|
@SlimDeluxe try running it, let me know how it goes on your end, I've been getting some issues locally |
SlimDeluxe
left a comment
There was a problem hiding this comment.
I pushed some quick fixes I found were necessary.
Moreover:
- The workbench/public dir is missing. You had it in .gitignore. Please set it up.
- It appears you made a mistake and committed a new file, lando.yml with only 1 added line compared to lando.dist.yml.
- There were some migrations problems. I tried fixing it, but the tests fail due to a 500 error - maybe because of the missing public dir. Please see about it.
This reverts commit 8d76155.
|
🤠🔫 |
|
When running tests locally, they now pass. But in CI, as you see, they're broken 🤢 |
This reverts commit 2ff16ee.
| <server name="CACHE_STORE" value="array"/> | ||
| <server name="DB_CONNECTION" value="sqlite"/> | ||
| <server name="DB_DATABASE" value=":memory:"/> | ||
| <server name="DB_DATABASE" value="workbench/database/database.sqlite"/> |
There was a problem hiding this comment.
I'm curious about why you switched to a file instead of :memory:, there must have been a reason? To my surprise both are equally fast (/slow).

No description provided.