Skip to content

feat(currency-seeder): implement currency seeder#16

Merged
SlimDeluxe merged 6 commits intoDataLinx:mainfrom
KilianTrunk:feat/currency-seeder
Aug 25, 2025
Merged

feat(currency-seeder): implement currency seeder#16
SlimDeluxe merged 6 commits intoDataLinx:mainfrom
KilianTrunk:feat/currency-seeder

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2025

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.14%. Comparing base (deb32c6) to head (738c040).

Files with missing lines Patch % Lines
src/Jobs/ImportCurrencies.php 0.00% 5 Missing ⚠️
src/Jobs/ImportCountries.php 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #16      +/-   ##
============================================
- Coverage     82.53%   82.14%   -0.40%     
- Complexity      158      160       +2     
============================================
  Files            25       25              
  Lines          1002     1008       +6     
============================================
+ Hits            827      828       +1     
- Misses          175      180       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SlimDeluxe
Copy link
Member

One test is failing, please check

@KilianTrunk
Copy link
Contributor Author

@SlimDeluxe where would you suggest we include the seeding? inside the eclipsephp-app or inside eclipsephp-core? eclipsephp-world-plugin is dependency of the eclipsephp-core, and eclipsephp-core is dependency of the eclipsephp-app?

@SlimDeluxe
Copy link
Member

I'm sorry I missed this question.
Create two files:

  1. CurrencySeeder: create the EUR, USD and GBP currency.
  2. WorldSeeder: just call the CurrencySeeder (for now).

Then we can call WorldSeeder from apps so that we have some data after a fresh migration.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you already have the CurrencySeeder. Just add WorldSeeder and we are good to go :)

@KilianTrunk KilianTrunk requested a review from SlimDeluxe August 22, 2025 07:39
@SlimDeluxe SlimDeluxe merged commit 09699f6 into DataLinx:main Aug 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants