feat(notifications): add real-time notifications to imports#8
Merged
SlimDeluxe merged 12 commits intoDataLinx:mainfrom Jul 11, 2025
Merged
feat(notifications): add real-time notifications to imports#8SlimDeluxe merged 12 commits intoDataLinx:mainfrom
SlimDeluxe merged 12 commits intoDataLinx:mainfrom
Conversation
Contributor
KilianTrunk
commented
Jul 8, 2025
KilianTrunk
commented
- Add ImportFinishedNotification with broadcast and database channels
- Connect ImportFinishedNotification with existing import modules
- Switch create/edit forms to use dialogs (same pattern as country) - Show country name with flag emoji in posts table - Enforce unique country+post-code key (DB migration + user-friendly UI error) - Add import script for SI and HR (prompt for country, run in background) - Extract all UI strings to lang files and add translations - Add tests for: • Posts CRUD • Access/permissions (mirror country resource tests) • Filtering by country • Preventing duplicate country+post-code combos
- Add ImportFinishedNotification with broadcast and database channels - Connect ImportFinishedNotification with existing import modules
SlimDeluxe
requested changes
Jul 9, 2025
Member
SlimDeluxe
left a comment
SlimDeluxe
left a comment
There was a problem hiding this comment.
Please run the code style fixing and see below code comments.
Will do another review after.
SlimDeluxe
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.