Skip to content

feat(regions): implement world regions#9

Merged
SlimDeluxe merged 11 commits intoDataLinx:mainfrom
KilianTrunk:feat/regions
Aug 14, 2025
Merged

feat(regions): implement world regions#9
SlimDeluxe merged 11 commits intoDataLinx:mainfrom
KilianTrunk:feat/regions

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since seeder runs before the country import, move the EU region seeding to the ImportCountries job, otherwise it's not doing anything, since countries do not yet exist.
  2. Special region management should be inside the country. It should be done with the Relation manager. This replaces this resource:
Image

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 88.14815% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.39%. Comparing base (07ad91e) to head (0512d88).

Files with missing lines Patch % Lines
...ament/Clusters/World/Resources/CountryResource.php 70.23% 25 Missing ⚠️
...lament/Clusters/World/Resources/RegionResource.php 92.85% 10 Missing ⚠️
src/Jobs/ImportCountries.php 92.00% 8 Missing ⚠️
src/Models/CountryInSpecialRegion.php 0.00% 2 Missing ⚠️
src/Policies/RegionPolicy.php 90.00% 2 Missing ⚠️
src/Models/Country.php 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #9      +/-   ##
============================================
+ Coverage     74.14%   81.39%   +7.25%     
- Complexity      109      161      +52     
============================================
  Files            20       25       +5     
  Lines           611     1016     +405     
============================================
+ Hits            453      827     +374     
- Misses          158      189      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When adding a special region that the country is already in, a user-friendly validation error should be shown instead of the database constraint error.
  2. EU (special region) is not shown in the country table filter. Maybe it's best to make a separate filter for special regions, to make it more clear. E.g. typing EU into the filter already returns many matches.
  3. The special region does not show the assigned country count
image 4. See code comment

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge recent changes from main and resolve the import script conflict.

@KilianTrunk
Copy link
Contributor Author

looks like this commit made tests start failing

@SlimDeluxe
Copy link
Member

@KilianTrunk ah sorry about that, please add eclipsephp/common to deps and it should work again.

@KilianTrunk
Copy link
Contributor Author

@SlimDeluxe looks like an issue with the L12 & F4 testing support we added, can I try to fix it in this PR?

@SlimDeluxe
Copy link
Member

We're not testing for F4, only L12. For F4 there's going to be code changes.
The problem seems to be that since Tuesday Filament stable is at 4.0. You have to modify this part to explicitly use 3.3.
image

@KilianTrunk KilianTrunk requested a review from SlimDeluxe August 14, 2025 11:34
@SlimDeluxe SlimDeluxe merged commit e1e3371 into DataLinx:main Aug 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants