feat(regions): implement world regions#9
Merged
SlimDeluxe merged 11 commits intoDataLinx:mainfrom Aug 14, 2025
Merged
Conversation
SlimDeluxe
requested changes
Jul 28, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
- Since seeder runs before the country import, move the EU region seeding to the
ImportCountriesjob, otherwise it's not doing anything, since countries do not yet exist. - Special region management should be inside the country. It should be done with the Relation manager. This replaces this resource:
…se Relation Manager
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
============================================
+ Coverage 74.14% 81.39% +7.25%
- Complexity 109 161 +52
============================================
Files 20 25 +5
Lines 611 1016 +405
============================================
+ Hits 453 827 +374
- Misses 158 189 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SlimDeluxe
requested changes
Jul 30, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
- When adding a special region that the country is already in, a user-friendly validation error should be shown instead of the database constraint error.
- EU (special region) is not shown in the country table filter. Maybe it's best to make a separate filter for special regions, to make it more clear. E.g. typing EU into the filter already returns many matches.
- The special region does not show the assigned country count
4. See code comment
… optimized imports
SlimDeluxe
requested changes
Aug 4, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
Please merge recent changes from main and resolve the import script conflict.
Contributor
Author
|
looks like this commit made tests start failing |
Member
|
@KilianTrunk ah sorry about that, please add eclipsephp/common to deps and it should work again. |
Contributor
Author
|
@SlimDeluxe looks like an issue with the L12 & F4 testing support we added, can I try to fix it in this PR? |
Member
SlimDeluxe
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.