feat(acl): owner may release/tombstone own instance + export WriteAclMode#170
Merged
Conversation
So downstream consumers (e.g. carl) can set ConfigOverrides.write_acl in their own integration tests without a direct escurel-server dependency.
The write check required the INCOMING owner to resolve to the caller, which broke legitimate self-mutation: /delete-my-data repoints an owner wikilink at a deleted placeholder (unresolvable) → was denied. Refine: owning the EXISTING page authorises any rewrite of it (including release/tombstone); the incoming-owner check applies only to CREATEs (no existing page) — still blocks create-for-/transfer-to another subject and public/admin-only creates. All prior write-ACL tests stay green; adds owner_may_tombstone_own_instance.
jrosskopf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two write-ACL fast-follows to #169:
fix(acl): owner may release/tombstone their own instance. feat(acl): deterministic per-instance WRITE ACL (owner-or-admin) #169 re-checked the incoming owner on every write, which broke legitimate self-mutation —/delete-my-datarepoints an owner wikilink at a deleted placeholder (unresolvable) and was denied. Now: owning the existing page authorises any rewrite (incl. release/tombstone); the incoming-owner check applies only to creates (no existing page), still blocking create-for-/transfer-to-another and public/admin-only creates. Addsowner_may_tombstone_own_instance; all prior write-ACL tests stay green.chore(test-support): re-exportWriteAclModeso consumers (carl) can setConfigOverrides.write_aclin their own integration tests.🤖 Generated with Claude Code