Skip to content
Merged
40 changes: 40 additions & 0 deletions docs/operations/code-review-11-disposition.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# CodeRabbit Review 11 Disposition

**Promotion PR:** [#11](https://github.com/DatabreezeService/databreeze-platform/pull/11)

**Review run:** `8cc266ad-874b-4781-a97d-ebe86b0eb521`

**Completed at (UTC):** 2026-08-02T09:28:06Z

**Invocation policy:** This was the one permitted full CodeRabbit review for PR #11. No second review will be requested.

## Valid issues fixed

The following ten valid issues (nine inline comments plus one task-conditional nitpick) were reproduced against the reviewed `dev` commit and are being fixed in focused commits before promotion:

1. The Luna bootstrap prompt now makes PostgreSQL migration/tenant tests conditional on durable-state changes and client coverage conditional on client behavior.
2. The evidence record stores the full source commit SHA while retaining the short display prefix.
3. The rollback note explains that reverting the reconciliation test removes `repo:check` enforcement and requires a fresh check.
4. Parallel-lane guidance now keeps CRF/PDA and MR/DQG serial by default and requires explicit interface-level control records before any overlap.
5. Android and Python normalized-key transformations are defined deterministically with examples.
6. The orchestration state section separates requirement states from plan/task states and includes all ledger vocabulary transitions.
7. The handoff record captures the CodeRabbit invocation timestamp in UTC.
8. Redis-loss recovery now fences stale workers and reconciles durable leases/effect receipts before redispatch.
9. Worktree instructions now select `feat/`, `fix/`, `docs/`, `ci/`, or another conventional prefix based on task type.
10. The orchestration path validator rejects backslashes, dot segments, parent segments, and resolved paths outside the repository root.

The review grouped the first item as a nitpick and the remaining items as inline comments; all are recorded here because they affect the safety contract.

## Rejected issues with evidence

### Duplicate plan catalog

CodeRabbit suggested moving the plan catalog out of `tools/repo-cli/src/check-execution-orchestration.mjs` and importing it from the test. The test intentionally keeps an independent expected catalog: it is the oracle that detects a checker or ledger silently dropping, reordering, or recounting a plan. Sharing the same map would allow the checker and test to drift together and would remove that protection. The current duplication is therefore deliberate and documented; no code change is made.

### Docstring coverage warning

The walkthrough reported a 0% docstring-coverage warning. Docstring coverage is not a repository check, release gate, or requirement in this project. The affected files are executable CLI/checker code and Markdown evidence, and adding decorative docstrings would not improve the validated behavior. The repository’s actual gates—format, lint, typecheck, contract parity, tests, builds, scans, Android checks, and infrastructure static checks—remain the acceptance evidence.

## Verification

Valid fixes must pass targeted tests, `corepack pnpm repo:check`, `corepack pnpm repo:build`, and the hosted checks on the follow-up `dev` PR. This document is evidence of the rejected comments and must remain in the promotion diff; it does not claim that a second CodeRabbit review occurred.
68 changes: 68 additions & 0 deletions docs/operations/foundation-reconciliation-2026-08-02.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# Engineering Foundation Reconciliation

**Evidence date:** 2026-08-02

**Source commit:** `86e72d8569057d2a14ed6bb1672ce6a573fa8d7c` (display prefix: `86e72d8`)

**Scope:** the merged engineering-foundation implementation and the 23 tasks in `docs/plans/010-engineering-foundation.md`.

**Requirement status:** no requirement promoted to `verified`; the foundation plan supplies only the partial coverage explicitly recorded in `docs/plans/requirement-traceability.json`.

## Reconciliation method

This record was created from the current merged `dev` checkpoint, not from an earlier model report. Each task was matched to its repository paths, tests, generated artifacts, operational documentation, and release boundary. A task is marked `reconciled` only when its repository evidence is present and the applicable fresh command passes. A task with an unavailable external tool remains `reconciled-with-limit` and cannot promote a production or infrastructure requirement.

## Task outcomes

| Task | Outcome | Evidence boundary |
|---|---|---|
| Task 1 | reconciled | Root workspace, runtime pins, package discovery, and clean bootstrap are present and covered by repository checks. |
| Task 2 | reconciled | Dependency-boundary checker and allowed/rejected fixture tests pass through the root lint gate. |
| Task 3 | reconciled | Requirement parser/index, duplicate/gap fixtures, and the 611-record checked index pass. |
| Task 4 | reconciled | Versioned base schemas, validation fixtures, and generated envelope checks pass. |
| Task 5 | reconciled | TypeScript, Kotlin, and Python generated outputs are current and parity-tested. |
| Task 6 | reconciled | Compatibility policy and 28-case cross-runtime fixture parity pass. |
| Task 7 | reconciled | Permission/tenant primitives and narrowing tests are present; persistence remains owned by later IAM work. |
| Task 8 | reconciled | Typed configuration and provider-port packages are present with public API/build tests. |
| Task 9 | reconciled | Vietnamese-first and English-complete catalogs, negotiation, formatting, and completeness tests pass. |
| Task 10 | reconciled | Three canonical DataBreeze assets and checksum gates are present; bytes remain immutable. |
| Task 11 | reconciled | Deterministic Web/Desktop/Android derivative generation, source provenance, and visual/geometry gates pass. |
| Task 12 | reconciled | Shared design tokens, CSS/TypeScript/Android outputs, contrast, reduced-motion, and drift tests pass. |
| Task 13 | reconciled | Web shell, bilingual routing, governed navigation, error boundary, accessibility, and test/build gates pass. |
| Task 14 | reconciled | Fastify API shell, readiness, correlation, Problem Details, OpenAPI, Prisma schema inventory, and tests pass. |
| Task 15 | reconciled | Electron main/preload/renderer shell, context isolation, CSP/navigation policy, and IPC boundary tests pass. |
| Task 16 | reconciled | Python `uv` project, typed action registry, framed entry points, deterministic processor, and engine checks/build pass. |
| Task 17 | reconciled | Kotlin/Compose shell, generated resources, Room/WorkManager/Keystore ports, network security, backup policy, and debug unit tests pass. |
| Task 18 | reconciled | PostgreSQL/Redis/MinIO/Mailpit/OpenTelemetry Compose definitions, health checks, and static readiness checks pass; live Docker startup is separately environment-gated. |
| Task 19 | reconciled-with-limit | AWS OpenTofu modules, alpha composition, encryption/private-network/OIDC source checks, and non-applying infrastructure check pass; OpenTofu itself is not installed locally, so format/validate remain hosted-check obligations. |
| Task 20 | reconciled | Content-safe telemetry package, correlation propagation, redaction allowlists, and hostile-attribute tests are present and covered by repository checks. |
| Task 21 | reconciled | Path-aware quality/security/release workflows, pinned actions, least-privilege permissions, SBOM/provenance, and scan definitions are present and hosted checks pass. |
| Task 22 | reconciled | Development, deployment, rollback, secret-rotation, provider-adapter, release-channel, support, and local-infrastructure runbooks are present. |
| Task 23 | reconciled | This clean-checkout record is backed by the fresh verification commands below and contains no runtime artifacts, credentials, or customer data. |

## Fresh verification evidence

The following commands were run from a clean worktree at source commit `86e72d8` after locked dependency bootstrap:

| Command | Result |
|---|---|
| `corepack pnpm install --frozen-lockfile` | Pass; lockfile and all 15 workspace projects installed. |
| `uv sync --locked --offline` in `services/engine` | Pass; locked Python 3.13 environment created. |
| `corepack pnpm repo:check` | Pass; formatting, lint, typecheck, orchestration/requirements/contract checks, repository CLI tests, and all workspace tests passed. |
| `corepack pnpm repo:build` | Pass; API, Web, Desktop, shared packages, and Python engine builds passed. |
| `apps/android/gradlew :app:testDebugUnitTest --no-daemon` from `apps/android` with the existing SDK path supplied | Pass; 27 Android debug unit-test tasks completed. |
| `corepack pnpm infra:check` | Pass; static AWS/local infrastructure checks passed without applying resources. |
| `git diff --check` | Pass; no whitespace errors. |

The repository checks include generated-contract drift, brand checksum/derivative drift, dependency boundaries, 28-case TypeScript/Python/Kotlin parity, scan policy, and the orchestration checker. The Web bundle emits its existing chunk-size advisory while remaining inside the enforced gzip budget.

## Known environment limits

- OpenTofu is not installed on this workstation. No AWS infrastructure was applied; hosted CI must run the pinned OpenTofu format/validate checks before an infrastructure PR is accepted.
- Docker is installed but live local dependency startup was not required for this reconciliation. Run `corepack pnpm local:smoke` on a healthy Docker daemon before dogfood acceptance.
- Android instrumentation/emulator testing and signed release packaging remain Plan 400 gates; the debug unit suite passed with the local SDK path supplied through `ANDROID_HOME`/`ANDROID_SDK_ROOT`.
- No customer data or credentials were used. Ignored dependency caches, virtual environments, build output, and Gradle state remain untracked.

## Release and rollback decision

FND-001 is complete as an evidence-reconciliation task. Plan 010 remains `partial-needs-reconciliation` until FND-002 through FND-007 close their independent gates and hosted OpenTofu validation is available. The next orchestration task is `FND-002`. Reverting this record and its test removes the reconciliation evidence and its `repo:check` enforcement; after such a rollback, run `corepack pnpm repo:check` and record the resulting gap before merging. The rollback does not alter application code, generated contracts, migrations, assets, or runtime state.
8 changes: 5 additions & 3 deletions docs/plans/000-platform-program.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ docs/plans/requirement-traceability.json records all 611 IDs with requested trac
- `main` contains stable releases. `dev` is the integration branch.
- New capabilities use `feat/<name>`; corrections use `fix/<name>`; operational and documentation work use conventional prefixes when more accurate.
- Commit one coherent tested unit at a time. Do not combine unrelated applications or domains merely to reduce commit count.
- Pull requests target `dev`, normally contain 30–50 commits, and must not exceed 70 commits.
- Invoke CodeRabbit once per pull request after the branch is ready for review. Validate every comment against the specifications and tests; fix valid findings and document why invalid findings are not applied.
- Promote `dev` to `main` only through a separate release pull request after the relevant production gates pass.
- Feature/fix pull requests target `dev`, preferably contain 30–50 commits, and must not exceed 60 commits. Run local and hosted checks, but do not invoke CodeRabbit on these integration pull requests.
- Merge a green integration pull request while preserving its atomic rollback commits, then immediately open a separate `dev` → `main` promotion pull request for that completed batch.
- Invoke CodeRabbit exactly once on the otherwise-ready promotion pull request and request a full review. Do not invoke it if the promotion exceeds 280 changed files; split or revert the batch first.
- Reproduce every CodeRabbit claim against the reviewed commit. Fix valid findings in focused commits, document rejected findings with evidence, rerun all affected gates, and never request a second CodeRabbit review on that pull request.
- Do not merge a promotion when the single review was skipped, timed out, has unresolved valid findings, or required hosted checks are not green.

## Cross-cutting definition of done

Expand Down
Loading
Loading