fix: address promotion PR #14 review findings - #15
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the single CodeRabbit review on promotion PR #14 through three reversible commits.\n\n- closes Android sync revocation, scheduling, queue ordering/cleanup, Keystore IV, and WorkManager initialization gaps\n- strengthens saved-state, account/workspace isolation, XML boundary, and revocation tests\n- records the PR #14 review disposition and refreshes the feature checkpoint\n\nValidation: Android unit/compile and connected instrumentation (3/3), corepack pnpm repo:check, repo:build, infra:check, and git diff --check.\n\nThe kapt→KSP suggestion was reproduced and rejected because the alias fails this repository's Gradle classpath configuration; the docstring warning is advisory and documented.