Skip to content

fix: address promotion review findings - #21

Merged
BeforeLights merged 12 commits into
devfrom
fix/promotion-20-review
Aug 2, 2026
Merged

fix: address promotion review findings#21
BeforeLights merged 12 commits into
devfrom
fix/promotion-20-review

Conversation

@BeforeLights

@BeforeLights BeforeLights commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • address valid CodeRabbit safety/correctness findings from promotion PR promote: foundation batch and platform gates #20
  • harden local Compose exposure, Docker lifecycle probes, persistence cleanup, and environment loading
  • normalize hostile telemetry reflection/provider failures
  • strengthen AWS policy/Fargate validation and parse CI workflows structurally
  • add artifact-content assertions and reconcile evidence/runbooks

Verification

  • corepack pnpm format:check
  • corepack pnpm lint
  • corepack pnpm typecheck
  • corepack pnpm test
  • corepack pnpm repo:build
  • uv run --locked ruff check src tests
  • uv run --locked ruff format --check src tests
  • uv run --locked mypy src
  • ./gradlew.bat :app:testDebugUnitTest --offline --no-daemon

This is a focused promotion-gate fix PR; the normal 30+ commit feature batching rule is intentionally not applied. No CodeRabbit review is requested here; PR #20 remains the single reviewed promotion PR.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 639375b3-165e-4709-b2e3-896cf9ec5fd6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@BeforeLights
BeforeLights merged commit 7a242f5 into dev Aug 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant