Create basic tests covering excavation & output generation for example.#4
Open
alexjeffburke wants to merge 2 commits intoDatamuseum-DK:mainfrom
Open
Create basic tests covering excavation & output generation for example.#4alexjeffburke wants to merge 2 commits intoDatamuseum-DK:mainfrom
alexjeffburke wants to merge 2 commits intoDatamuseum-DK:mainfrom
Conversation
alexjeffburke
force-pushed
the
run_example-basic-tests
branch
from
ecf81c1 to
de31c14
Compare
Support a directory argument of "." to allow outputting to an output folder in the cwd with an automatic suffix: ./_autoarchaologist While here add top level run_example wrapper shell script in advance of a future change to provide a unified run CLI.
… run. Make the minimal set of changes such that we are able to trigger the excavation to a known directory of the in-tree example file. Check that the expected HTML files were written for this known excavation and assert some basic properties of the excavated artifacts. The commit includes reworking of run_example wherein its excavation is declared as a class and its core logic separated out into a run.py file. This is done both to allow the tests to easily make use of the logic and as preliminary bits for subsequent work to provide a unified entry point.
alexjeffburke
force-pushed
the
run_example-basic-tests
branch
from
de31c14 to
51dba3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the minimal set of changes such that we are able to trigger the
excavation to a known directory of the in-tree example file. Check
that the expected HTML files were written for this known excavation
and assert some basic properties of the excavated artefacts.
The commit includes reworking of run_example wherein its excavation is
declared as a class and its core logic separated out into a run file.
This is done both to allow the tests to easily make use of the logic
and as groundwork for subsequent work to provide a unified entry point.