chore: pin overlay images to immutable sha- tags#1
Merged
Conversation
Replace floating dev/staging/prod tags with a sha-0000000 placeholder in each overlay's kustomization.yaml. Floating tags let ArgoCD sync whatever currently has that name in GHCR, which is non-reproducible and makes rollback ambiguous. CI (bump-dev-overlay / promote.yml) is now the only thing expected to update this value, via 'kustomize edit set image'. Placeholder will be replaced by a real digest on the first successful CI run.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Kustomize overlays for the dev, staging, and prod environments of the sample-app. Specifically, it replaces the floating image tags (dev, staging, prod) with a placeholder immutable SHA tag (sha-0000000) and adds explanatory comments detailing that CI will manage these values. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces floating
dev/staging/prodtags in each overlay'skustomization.yamlwith asha-0000000placeholder.Why: floating tags let ArgoCD sync whatever currently has that name in GHCR — non-reproducible, and rollback becomes ambiguous (which image was actually running?). CI (
bump-dev-overlay/promote.yml) becomes the only thing expected to update this value, viakustomize edit set image.Verified with
kustomize buildon all three overlays.