Skip to content

deploy(dev): sample-app sha-54f8a2e#6

Merged
David-Uka merged 1 commit into
mainfrom
deploy/dev-sha-54f8a2e
Jul 7, 2026
Merged

deploy(dev): sample-app sha-54f8a2e#6
David-Uka merged 1 commit into
mainfrom
deploy/dev-sha-54f8a2e

Conversation

@David-Uka

Copy link
Copy Markdown
Owner

Automated dev image bump from sample-app CI run 28874930610.

@David-Uka
David-Uka merged commit 2662134 into main Jul 7, 2026
0 of 3 checks passed
@David-Uka
David-Uka deleted the deploy/dev-sha-54f8a2e branch July 7, 2026 14:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the development overlay configuration for sample-app by reformatting the resources and patches, and updating the image tag to sha-54f8a2e. Feedback was provided regarding a redundant newName field in the image configuration, which can be avoided by adjusting the CI pipeline's kustomize command.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +22 to +24
- name: ghcr.io/david-uka/sample-app
newName: ghcr.io/david-uka/sample-app
newTag: sha-54f8a2e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newName field is redundant because it is identical to the name field. This redundancy is typically introduced when the CI pipeline runs kustomize edit set image with the = syntax (e.g., kustomize edit set image <image>=<image>:<tag>).

To avoid this redundancy and keep the configuration clean, you can update the CI pipeline to use the simpler syntax:

kustomize edit set image ghcr.io/david-uka/sample-app:sha-54f8a2e

This will only update the newTag field and omit the redundant newName field.

- name: ghcr.io/david-uka/sample-app
  newTag: sha-54f8a2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant