Rename tool to Inference Runtime#2
Conversation
There was a problem hiding this comment.
Code Review
This pull request rebrands the project from "AI Inference Platform" to "Inference Runtime" across the documentation, FastAPI configuration, Docker image names, and Kubernetes manifests. The renaming covers deployments, services, horizontal pod autoscalers, and monitoring configurations. One piece of feedback suggests that for complete consistency, the underlying Prometheus metric names should also be updated to use the new prefix, which would require changes in the API metrics definitions and the corresponding Grafana dashboard queries.
| "title": "Inference Runtime", | ||
| "uid": "inference-runtime", |
There was a problem hiding this comment.
While the dashboard title and UID have been updated, the underlying metric queries still use the old ai_api_ prefix (e.g., ai_api_http_requests_total, ai_api_inference_latency_seconds_bucket). For consistency with the renaming of the service to inference-api, consider updating these metric names to use a prefix like inference_api_. This would likely require changes in api/metrics.py to rename the metrics at the source, and then updating the queries in this dashboard to match.
Summary
Testing