Skip to content

ci: add analyze-iwyu required check, bump cpputest-clang image #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidCozens merged 4 commits into from
May 4, 2026
Merged

ci: add analyze-iwyu required check, bump cpputest-clang image #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1f34f9
ci: add analyze-iwyu required check, bump cpputest-clang to sha-7eac3ab
DavidCozens May 4, 2026
f37311f
ci: surface analyze-iwyu in PR Quality Monitor summary
DavidCozens May 4, 2026
90f115f
ci: drop analyze-iwyu Quality Monitor analysis entry, keep artifact d…
DavidCozens May 4, 2026
f6f6510
ci: pin upload/download-artifact in analyze-iwyu and summary
DavidCozens May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ services:
command: sleep infinity

clang:
image: ghcr.io/davidcozens/cpputest-clang:sha-0385cea
image: ghcr.io/davidcozens/cpputest-clang:sha-7eac3ab
volumes:
- ..:/workspaces/SolidSyslog:cached
- ${SSH_AUTH_SOCK:-/dev/null}:/ssh-agent
Expand Down
40 changes: 38 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
contents: read
checks: write
container:
image: ghcr.io/davidcozens/cpputest-clang:sha-0385cea
image: ghcr.io/davidcozens/cpputest-clang:sha-7eac3ab
options: --user root
env:
GIT_CONFIG_COUNT: 1
Expand Down Expand Up @@ -289,6 +289,34 @@ jobs:
path: build/tidy/clang-tidy-output.txt
retention-days: 1

analyze-iwyu:
runs-on: ubuntu-latest
container:
image: ghcr.io/davidcozens/cpputest-clang:sha-7eac3ab
options: --user root
env:
GIT_CONFIG_COUNT: 1
GIT_CONFIG_KEY_0: safe.directory
GIT_CONFIG_VALUE_0: '*'

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Configure
run: cmake --preset iwyu

- name: Run include-what-you-use
shell: bash
run: set -o pipefail && cmake --build --preset iwyu --target iwyu 2>&1 | tee build/iwyu/iwyu-output.txt

- name: Upload iwyu output
if: success() || failure()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
name: iwyu-report
path: build/iwyu/iwyu-output.txt
retention-days: 1

analyze-format:
runs-on: ubuntu-latest
container:
Expand Down Expand Up @@ -549,7 +577,7 @@ jobs:

summary:
if: always() && github.event_name == 'pull_request'
needs: [build-linux-gcc, build-linux-clang, sanitize-linux-gcc, coverage-linux-gcc, analyze-tidy, analyze-cppcheck, analyze-format, bdd-linux-syslog-ng, build-windows-msvc, bdd-windows-otel, integration-linux-openssl]
needs: [build-linux-gcc, build-linux-clang, sanitize-linux-gcc, coverage-linux-gcc, analyze-tidy, analyze-cppcheck, analyze-format, analyze-iwyu, bdd-linux-syslog-ng, build-windows-msvc, bdd-windows-otel, integration-linux-openssl]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -578,6 +606,14 @@ jobs:
with:
name: cppcheck-report
path: quality-reports/

- name: Download iwyu report
continue-on-error: true
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
with:
name: iwyu-report
path: quality-reports/

- name: Quality Monitor
uses: uhafner/quality-monitor@v1
with:
Expand Down
1 change: 1 addition & 0 deletions docs/ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ without renaming what's already there.
| `analyze-tidy` | `tidy` | clang-tidy — pass/fail with errors in job log |
| `analyze-cppcheck` | `cppcheck` | cppcheck static analysis |
| `analyze-format` | — | clang-format dry-run; fails if any file needs reformatting |
| `analyze-iwyu` | `iwyu` | include-what-you-use; fails on missing or unused `#include` directives |
| `integration-linux-openssl` | `debug` | Runs the in-process TLS integration tests against libssl (no network oracle) |
| `bdd-linux-syslog-ng` | — | End-to-end BDD test via Docker Compose (syslog-ng + Behave), Linux runner |
| `bdd-windows-otel` | — | Windows-eligible BDD scenarios driven against an OTel Collector oracle |
Expand Down
2 changes: 1 addition & 1 deletion docs/containers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
| Image | Tag | Used by |
|---|---|---|
| `ghcr.io/davidcozens/cpputest` | `sha-18f19e1` | devcontainer (`gcc` service), all CI jobs except clang |
| `ghcr.io/davidcozens/cpputest-clang` | `sha-0385cea` | `clang` compose service, `build-linux-clang` CI job |
| `ghcr.io/davidcozens/cpputest-clang` | `sha-7eac3ab` | `clang` compose service, `build-linux-clang` CI job, `analyze-iwyu` CI job |
| `balabit/syslog-ng` | `latest` | `syslog-ng` service — BDD test oracle |
| `ghcr.io/davidcozens/behave` | `sha-3faff14` | `behave` service — Debian trixie + Python 3.12 + Behave for BDD scenarios |

Expand Down
Loading