feat: S08.02 QEMU -icount determinism mode and analyze-iwyu required check#287
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds QEMU instruction-count determinism flags ( ChangesQEMU Determinism and CI Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…check - ci.yml: -icount shift=auto,sleep=off,align=off on the build-freertos-target QEMU invocation. Forward-compatibility for the BDD timing scenarios in S08.03+; no behavioural change at this story. - CLAUDE.md: required-checks list updated to match the actual GitHub state (analyze-iwyu, integration-windows-openssl, build-freertos-host-tdd, build-freertos-target). - DEVLOG.md appended. Branch-protection update (adding analyze-iwyu as a required context) is applied via gh api alongside this PR. Closes #267 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
e15fb3f to
ca02f31
Compare
☀️ Quality Summary 🚦 build-linux-gcc: 100% successful (✔️ 1096 passed, 🙈 3 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
Purpose
Closes #267 (S08.02 — Hello-world running under QEMU on CI).
S08.01 already wired
build-freertos-targetandbuild-freertos-host-tddand (out-of-band) someone added them to branch protection. So the CI plumbing the story asks for is already in place. This PR tidies the two remaining loose ends, sized to David's "this hello-world is a stepping stone — don't over-engineer it" steer.Change Description
-icount shift=auto,sleep=off,align=offadded to theqemu-system-arminvocation inbuild-freertos-target. Decouples FreeRTOS scheduler timing from CI runner load. No behavioural change for the current hello-world smoke (still races to print the greeting and gets killed bytimeout 5), but it is the determinism mode the timing-sensitive BDD scenarios coming in S08.03+ will need, and it costs nothing now.analyze-iwyuadded to required status checks onmainviagh api. S24.01 added the job but the branch-protection update was missed.analyze-iwyu,integration-windows-openssl,build-freertos-host-tdd,build-freertos-targetto the documented list (they were all pinned but undocumented).Deliberately not done
timeout 5/grepis fine for a stepping-stone smoke.Example/FreeRtos/HelloWorld/. Keeping the CI ELF identical to the dev-tested ELF stays load-bearing.Test Evidence
build-freertos-targetjob.gh apiPOST:analyze-iwyunow appears inrequired_status_checks.contexts.Areas Affected
.github/workflows/ci.yml— single-job change tobuild-freertos-target.main(out of repo, applied viagh api).CLAUDE.md,DEVLOG.md— documentation only.🤖 Generated with Claude Code
Summary by CodeRabbit
analyze-iwyu,integration-windows-openssl,build-freertos-host-tdd/build-freertos-target) for stricter code quality validation on pull requests.