chore: bump container image to sha-bbc958b#351
Conversation
Picks up the FatFs R0.16 swap from CppUTestFreertosDocker#1 — Plus-FAT is gone from the image, FatFs is now at /opt/fatfs with FATFS_PATH set. Prerequisite for SolidSyslog #270 (S08.05) which targets FatFs as its embedded persistent-store backend. - .devcontainer/docker-compose.yml — freertos-host, freertos-target - .github/workflows/ci.yml — build-freertos-host-tdd, build-freertos-target - ci/docker-compose.bdd.yml — behave-freertos - docs/containers.md — both image rows; Plus-FAT -> FatFs in env-vars text - Platform/FreeRtos/CMakeLists.txt — drop Plus-FAT mention from header-configured rationale (Plus-FAT no longer in image) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR updates FreeRTOS container image references from SHA ChangesFreeRTOS Container Image Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
☀️ Quality Summary 🚦 build-linux-gcc: 100% successful (✔️ 1112 passed, 🙈 3 skipped) Created by Quality Monitor v1.14.0 (#f3859fd). More details are shown in the GitHub Checks Result. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/containers.md (1)
66-66:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd
ci/docker-compose.bdd.ymlto thecpputest-freertos-crossupdate list.The
behave-freertosservice inci/docker-compose.bdd.yml(line 90) usescpputest-freertos-cross, and this PR correctly updated it. However, the "Files to update" table doesn't listci/docker-compose.bdd.ymlfor this image, which could cause that reference to be missed in future updates.📝 Proposed fix
-| `cpputest-freertos-cross` | `.devcontainer/docker-compose.yml`, `.github/workflows/ci.yml`, `docs/containers.md` | +| `cpputest-freertos-cross` | `.devcontainer/docker-compose.yml`, `.github/workflows/ci.yml`, `ci/docker-compose.bdd.yml`, `docs/containers.md` |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/containers.md` at line 66, Update the "Files to update" table row for the entry `cpputest-freertos-cross` in docs/containers.md so it includes `ci/docker-compose.bdd.yml` alongside the existing `.devcontainer/docker-compose.yml`, `.github/workflows/ci.yml`, and `docs/containers.md`; locate the table row containing the text "`cpputest-freertos-cross` | `.devcontainer/docker-compose.yml`, `.github/workflows/ci.yml`, `docs/containers.md`" and append `, ci/docker-compose.bdd.yml` to that list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/containers.md`:
- Line 66: Update the "Files to update" table row for the entry
`cpputest-freertos-cross` in docs/containers.md so it includes
`ci/docker-compose.bdd.yml` alongside the existing
`.devcontainer/docker-compose.yml`, `.github/workflows/ci.yml`, and
`docs/containers.md`; locate the table row containing the text
"`cpputest-freertos-cross` | `.devcontainer/docker-compose.yml`,
`.github/workflows/ci.yml`, `docs/containers.md`" and append `,
ci/docker-compose.bdd.yml` to that list.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 94872516-b332-44c2-b6d9-9c171ebc432d
📒 Files selected for processing (5)
.devcontainer/docker-compose.yml.github/workflows/ci.ymlPlatform/FreeRtos/CMakeLists.txtci/docker-compose.bdd.ymldocs/containers.md
Purpose
Picks up the FatFs R0.16 swap from CppUTestFreertosDocker#1. Plus-FAT is gone from the image; FatFs is now at `/opt/fatfs` with `FATFS_PATH` set.
Prerequisite for #270 (S08.05 — Store-and-forward on FatFs), which targets FatFs as its embedded persistent-store backend.
Change Description
Per the `docs/containers.md` "Updating an image" checklist:
DEVLOG entries from 2026-04-21 (S08.01) that historically mention "Plus-FAT" are left alone — those describe the state at the time and shouldn't be rewritten.
Test Evidence
Pre-push verification on the new image:
```
$ docker run --rm ghcr.io/davidcozens/cpputest-freertos:sha-bbc958b bash -c 'env | grep -E "FATFS|FREERTOS|MBEDTLS" | sort && ls /opt/fatfs/source/'
FATFS_PATH=/opt/fatfs
FREERTOS_KERNEL_PATH=/opt/freertos/kernel
FREERTOS_PLUS_TCP_PATH=/opt/freertos/plus-tcp
MBEDTLS_DIR=/opt/mbedtls
00history.txt 00readme.txt diskio.c diskio.h ff.c ff.h ffconf.h ffsystem.c ffunicode.c
```
`/opt/freertos/plus-fat` correctly absent. CI on this PR rebuilds the FreeRTOS host TDD and cross-build jobs against the new image SHA — that's the integration check.
Areas Affected
Devcontainer, CI workflow, BDD compose file, container reference docs, FreeRTOS adapter pack rationale comment. No production code touched.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation