-
Notifications
You must be signed in to change notification settings - Fork 0
feat: S14.08 make SolidSyslogFormatter library-private (#548) #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2da7680
feat: S14.08 add SolidSyslogEndpointHost sink (slice 1)
DavidCozens d97c234
feat: S14.08 route endpoint host through the sink (slice 2)
DavidCozens e7c50eb
feat: S14.08 make SolidSyslogFormatter library-private (#548)
DavidCozens 8471326
docs: S14.08 refresh public-header table and OriginSd compliance notes
DavidCozens 8dbe422
chore: S14.08 pre-PR — MISRA suppressions, formatting, DEVLOG
DavidCozens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| #ifndef SOLIDSYSLOGENDPOINTHOST_H | ||
| #define SOLIDSYSLOGENDPOINTHOST_H | ||
|
|
||
| #include "ExternC.h" | ||
|
|
||
| #include <stddef.h> | ||
|
|
||
| EXTERN_C_BEGIN | ||
|
|
||
| /* The value sink for a destination host (the SolidSyslogEndpoint a sender | ||
| * hands its endpoint callback). A callback is given only a | ||
| * SolidSyslogEndpointHost* — it can append the host string bounded to the | ||
| * host-field width, but cannot reach the raw formatter. Unlike a header | ||
| * field, the bytes are copied verbatim: a DNS name or IP literal headed to | ||
| * the resolver must not be silently substituted. Stack-transient, no pool | ||
| * (D.002). */ | ||
| struct SolidSyslogEndpointHost; | ||
|
|
||
| /* Appends up to maxLength bytes of source (stopping at a NUL terminator) | ||
| * verbatim into the host sink, further bounded by the host-field width the | ||
| * sink was created with. */ | ||
| void SolidSyslogEndpointHost_String(struct SolidSyslogEndpointHost * host, const char* source, size_t maxLength); | ||
|
|
||
| EXTERN_C_END | ||
|
|
||
| #endif /* SOLIDSYSLOGENDPOINTHOST_H */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #include "SolidSyslogEndpointHostPrivate.h" | ||
|
|
||
| #include "SolidSyslogFormatter.h" | ||
|
|
||
| void SolidSyslogEndpointHost_FromFormatter(struct SolidSyslogEndpointHost* host, struct SolidSyslogFormatter* formatter) | ||
| { | ||
| host->Formatter = formatter; | ||
| } | ||
|
|
||
| void SolidSyslogEndpointHost_String(struct SolidSyslogEndpointHost* host, const char* source, size_t maxLength) | ||
| { | ||
| SolidSyslogFormatter_BoundedString(host->Formatter, source, maxLength); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File inserted in incorrect alphabetical position.
SolidSyslogEndpointHost.c(line 38) appears afterSolidSyslogHeaderField.c(line 37), but alphabetically "EndpointHost" should precede "HeaderField". TheSOURCESlist appears to maintain alphabetical order.📋 Suggested fix
Move
SolidSyslogEndpointHost.cto precedeSolidSyslogHeaderField.c:SolidSyslogSdValue.c SolidSyslogSdElement.c + SolidSyslogEndpointHost.c SolidSyslogHeaderField.c - SolidSyslogEndpointHost.c SolidSyslogTimeQualitySd.c🤖 Prompt for AI Agents