Skip to content

fix: prevent effect restarts when options are unchanged - #23

Merged
DavidHDev merged 2 commits into
DavidHDev:mainfrom
phh235:fix/skip-unchanged-effect-options
Aug 3, 2026
Merged

fix: prevent effect restarts when options are unchanged#23
DavidHDev merged 2 commits into
DavidHDev:mainfrom
phh235:fix/skip-unchanged-effect-options

Conversation

@phh235

@phh235 phh235 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Prevents unnecessary effect restarts when setOptions() receives values identical to the current configuration.

This adds an early-return check across 22 vanilla effects, avoiding redundant canvas/WebGL reinitialization and improving runtime stability and performance.

Type of change

  • Bug fix

Checklist

  • npx tsc --noEmit passes
  • npm run lint passes
  • npm run build passes
  • Tested in Chrome (with the html-in-canvas flag, if relevant)
  • Tested the WebGL overlay fallback (flag off / Safari / Firefox), if a component changed

@DavidHDev

Copy link
Copy Markdown
Owner

Hi @phh235 , there have been some changes in the Asciify and RetroDither components, leading to conflicts, please fix these before merge, I wasn't able to get Copilot to do it.

@phh235

phh235 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi @phh235 , there have been some changes in the Asciify and RetroDither components, leading to conflicts, please fix these before merge, I wasn't able to get Copilot to do it.

I'm done sir, ready to merge.

@DavidHDev

Copy link
Copy Markdown
Owner

Many thanks!

@DavidHDev
DavidHDev merged commit 880de31 into DavidHDev:main Aug 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants