test: cover imported extension assembly identity collisions#2805
Merged
Conversation
Document the declaring-assembly invariant and cover colliding extension-host type names with metadata and runtime assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Replace the issue-specific fix framing with reference-order-independent metadata and runtime coverage for colliding extension host type names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemberRefretains the declaring assembly identityThe reported failure does not reproduce on current
main; history shows declaring-assembly emission predates the affected release line. This PR therefore records the invariant as regression coverage rather than claiming a production behavior change.Security
The regression covers assembly/type confusion where a same-named type in another referenced assembly could otherwise capture a member reference and redirect or break execution. No new runtime surface is introduced.
Tests
dotnet test test/Compiler.Tests/Compiler.Tests.csproj --filter FullyQualifiedName~ImportedExtensionDeclaringAssemblyInvariantEmitTests --no-restore --nologoCloses #2801