fix: bind lambdas to imported byref delegates#2806
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Use the bound DelegateTypeSymbol signature for strict lambda conversion checks so source and imported delegates enforce identical ref/out/in matching. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
Read ref/out/in metadata from bound source and CLR method groups so delegate conversions and overload ranking validate the actual callable signature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a96d2bd-106a-4cb2-87ee-cef68a8a77f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in/ref/outmetadatainmodreqs match between definitions and member referencesSecurity
Exact ref-kind validation prevents unsafe byref aliasing, mutation, overload confusion, and signature drift. Independent Opus 4.8 reviews found no remaining security or correctness issues.
Tests
dotnet test test/Compiler.Tests/Compiler.Tests.csproj --filter FullyQualifiedName~ImportedMemberMatrix --no-restore --nologodotnet test test/Core.Tests/Core.Tests.csproj --filter FullyQualifiedName~RefKindParameter --no-restore --nologoCloses #2802