Skip to content

Document JP func_80082BC8_837C8 and rename to draw_text_with_shadow#719

Merged
DavidSM64 merged 2 commits intoDavidSM64:masterfrom
davozebi:rename-jp-draw-text-with-shadow
Mar 29, 2026
Merged

Document JP func_80082BC8_837C8 and rename to draw_text_with_shadow#719
DavidSM64 merged 2 commits intoDavidSM64:masterfrom
davozebi:rename-jp-draw-text-with-shadow

Conversation

@davozebi
Copy link
Copy Markdown
Contributor

@davozebi davozebi commented Mar 27, 2026

Document and rename JP-only function func_80082BC8_837C8 to draw_text_with_shadow. The else block is effectively unreachable because dialogueBoxID is always -1.

@davozebi davozebi marked this pull request as ready for review March 27, 2026 23:37
Copy link
Copy Markdown
Owner

@DavidSM64 DavidSM64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@DavidSM64 DavidSM64 merged commit b44c888 into DavidSM64:master Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants