Force-translate dynamic content to English in remaining display sites#8
Merged
Conversation
The previous force-English wiring covered grids, info-page title, history, timeline cards, and the info-page summary. This patch extends it to every remaining place where Bangumi or plugin-API data was still rendered in its source language (Chinese/Japanese): - Anime alias bottom sheet (the screen the user reported) - Character cards, character full page (name, nameCN, info, summary) - Staff cards (name, nameCN, position cn label) - Plain-text user comment body - Tag chips on the info page - Download manager: anime title and episode names - Download episode picker: episode identifier - Episode-comments sheet: episode title in header and selection list - Image-search result anime title - Video page: collection title in toolbar, episode identifier in road list - Watch-history card: last-watch episode name - Plugin search results in source sheet (anime title returned by plugin) The underlying data (used as plugin search keywords / storage identifiers / URL routing) is never mutated - translation happens only at display time via TranslatedText, falling back to the original on cache miss or network error. Co-authored-by: DeadEnd Dev <283450271+Deadendev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous force-English wiring covered grids, info-page title, history, timeline cards, and the info-page summary. This patch extends it to every remaining place where Bangumi or plugin-API data was still rendered in its source language (Chinese/Japanese):
The underlying data (used as plugin search keywords / storage identifiers / URL routing) is never mutated - translation happens only at display time via TranslatedText, falling back to the original on cache miss or network error.