Skip to content

Cursor/critical correctness bugs 3a41 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DealPatrol wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cursor/critical correctness bugs 3a41 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb39b6c
fix: harden auth cookies and stripe webhooks
cursoragent May 25, 2026
20d4087
Potential fix for pull request finding
DealPatrol May 26, 2026
df9b2a3
Merge branch 'main' into cursor/critical-correctness-bugs-3a41
DealPatrol May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/api/auth/github/callback/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { NextRequest, NextResponse } from 'next/server'
import { cookies } from 'next/headers'
import { getDb } from '@/lib/db'
import { GITHUB_ACCESS_TOKEN_COOKIE } from '@/lib/auth'
import { GITHUB_ACCESS_TOKEN_COOKIE, sanitizeReturnTo } from '@/lib/auth'
import { upsertSubscription } from '@/lib/queries'

function getBaseUrl(request: NextRequest) {
Expand All @@ -21,7 +21,7 @@ export async function GET(request: NextRequest) {
const errorDescription = searchParams.get('error_description')
const cookieStore = await cookies()
const savedState = cookieStore.get('github_oauth_state')?.value
const returnTo = cookieStore.get('github_oauth_return_to')?.value || '/dashboard/repositories?connected=github'
const returnTo = sanitizeReturnTo(cookieStore.get('github_oauth_return_to')?.value)

if (error) {
console.error('[v0] GitHub returned OAuth error:', error, errorDescription)
Expand Down
3 changes: 2 additions & 1 deletion app/api/auth/github/login/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import crypto from 'node:crypto'
import { NextRequest, NextResponse } from 'next/server'
import { sanitizeReturnTo } from '@/lib/auth'

function getBaseUrl(request: NextRequest) {
return process.env.NEXT_PUBLIC_APP_URL || request.nextUrl.origin
Expand All @@ -18,7 +19,7 @@ export async function GET(request: NextRequest) {

const state = crypto.randomUUID()
const redirectUri = `${getBaseUrl(request)}/api/auth/github/callback`
const returnTo = request.nextUrl.searchParams.get('returnTo') || '/dashboard/repositories?connected=github'
const returnTo = sanitizeReturnTo(request.nextUrl.searchParams.get('returnTo'))

const params = new URLSearchParams({
client_id: clientId,
Expand Down
Loading
Loading