Fail app builds on generation or push errors#86
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
The
/api/build-appstream could reportdoneeven when Claude failed to generate a file or GitHub/GitLab rejected a file push. Users would see “Built!” and receive a repo link even though the repo contained placeholder error files or was missing files.Root cause
The per-file generation loop converted generation exceptions into
# Error generating ...file content, and the GitHub/GitLab push helpers only logged non-OK responses instead of throwing. The loop incremented the pushed counter and emitted success regardless.Fix
errorevent when generation or push fails, instead of emittingdone.Validation
pnpm exec tsc --noEmitpnpm exec eslint app/api/build-app/route.tsPOST /api/build-appcovering generation failure, push failure, duplicate path dedupe, and successful completion.