Skip to content

Fail build app stream on generation or push errors#88

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-investigation-cf23
Draft

Fail build app stream on generation or push errors#88
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/critical-bug-investigation-cf23

Conversation

@cursor

@cursor cursor Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Bug and impact

The Build This App API could report success even when Claude failed to generate a file or GitHub/GitLab rejected a file write. In those cases users saw a completed build while the created repository was missing files or contained generated error stubs.

Root cause

Per-file generation errors were converted into placeholder file contents, and repository push helpers only logged non-2xx API responses instead of failing the SSE stream.

Fix

  • Throw on failed GitHub/GitLab file writes.
  • Emit an SSE error and stop the stream on generation or push failures.
  • Avoid double-closing the stream on early exits by relying on the existing finally close.

Validation

  • pnpm exec tsc --noEmit
  • pnpm exec eslint app/api/build-app/route.ts
  • Temporary mocked route harness verified success emits done, while AI generation failure and GitHub push rejection emit error and never emit done.
Open in Web View Automation 

Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
repo-app-architect Ready Ready Preview, Comment Jun 10, 2026 11:07am
repofuse Ready Ready Preview, Comment, Open in v0 Jun 10, 2026 11:07am
v0-repo-app-architect Ready Ready Preview, Comment, Open in v0 Jun 10, 2026 11:07am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant