Fix build-app false success and blueprint scoping leak#90
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Cole Collins <DealPatrol@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
/api/build-appreporteddoneeven when Claude generation failed or GitHub/GitLab file pushes returned non-2xx, leaving users with empty/partial repos shown as successful.getAllBlueprints('')fell back to an unscoped query and could expose all tenants' blueprints when auth had a GitHub session but no DB user id.Root cause
getAllBlueprintstreated a missing user id as permission to query all blueprints.Fix
step: 'error'on generation or push failure; nodoneevent is emitted.BUILD_APP_COSTbefore build work and refund it on repository creation, generation, push, or unexpected failures.getAllBlueprints; missing ids now return an empty list.Validation
pnpm exec eslint app/api/build-app/route.ts lib/queries.tspnpm exec tsc --noEmit/api/build-approute harness: success emitsdonewith one deduction/no refund; generation failure emits terminalerror, no push, one refund; push failure emits terminalerror, one refund; insufficient credits emitserrorand never creates a repo.getAllBlueprintsguard: blank user id returns[]without touching DB; scoped user id issues aJOIN analyses ... WHERE a.user_id = $userIdquery.