Open
Conversation
Add client-side validation to reject files exceeding 20MB before sending to the API, preventing GPU timeouts from oversized uploads. - Add MAX_FILE_SIZE constant and FileTooLargeError exception class - Validate file size in both process and queue request handlers - Add reference_image to FILE_FIELDS in process and queue clients - Export FileTooLargeError and MAX_FILE_SIZE from package root - Add unit tests for size limit enforcement
Add optional max_file_size field to ModelDefinition so models can override the default 20MB limit. lucy-restyle-v2v (longform video) gets a 100MB limit while all other models keep the 20MB default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileTooLargeErrorexception class andMAX_FILE_SIZEconstantreference_imagetoFILE_FIELDSin both process and queue clients (was missing)Changes
decart/errors.py— NewMAX_FILE_SIZEconstant +FileTooLargeErrorexceptiondecart/process/request.py— Size validation insend_request()afterfile_input_to_bytes()decart/queue/request.py— Size validation insubmit_job()afterfile_input_to_bytes()decart/client.py— Addedreference_imagetoFILE_FIELDSdecart/queue/client.py— Addedreference_imagetoFILE_FIELDSdecart/__init__.py— ExportFileTooLargeErrorandMAX_FILE_SIZEtests/test_process.py— 2 new tests (over limit, at limit)tests/test_queue.py— 1 new test (over limit)Testing