Draft
Conversation
4 tasks
Sanitizer Performance Benchmark
Threshold: >15% regression flagged with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is only a reference, I'll add the NKI Beta 2 interpreter in several stages based on the plan listed here
Summary
Test Plan
test_nkilib_interpreter_e2e.py(usesnkilib, which is bundled withnkiand are NKI kernels for various ops like RMSNorm, projection, etc.)examples/nkiNKI beta 2 kernels (matmul, rmsnorm, rope, softmax, attention) to make sure they equal numpy implsRelated Issues
This will be merged in several stages.
stage 1: dtypes foundation (current PR)
Scope:
triton_viz/utils/dtypes.pywithSTORAGE_DTYPESbacked byml_dtypesfor low-precision formats.Files:
triton_viz/utils/dtypes.pytests/unit/test_dtypes.pyValidation:
pytest tests/unit/test_dtypes.pystage 2: beta2 interpreter scaffold (side-by-side)
Scope:
triton_viz/core/nki_beta2.pywithout routing trace/patch to it yet.stage 3: runtime wiring switch
Scope:
trace.py,patch.py,client.py).stage 4: op coverage expansion
Scope:
nl/nisaoperation support innki_beta2.py.stage 5: hardening cleanup
Scope:
590d058,9873ccd,0692573) as cleanup-only PRs.stage 6: test expansion
Scope:
b218865+ quantization-related updates from8ecd095).stage 7: beta2 examples
Scope:
rmsnorm_beta2.py,rope_beta2.py,softmax_beta2.py,tiled_attention_beta2.py,nki2.py).Breaking Changes
Once this is fully merged with triton-viz support, I'll remove the old NKI interpreter since it's deprecated and incomplete
Checklist
npm run build:frontendif the PR modified any TypeScript code.