Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 40.00% 40.00%
=======================================
Files 23 23
Lines 2130 2130
Branches 327 327
=======================================
Hits 852 852
Misses 1177 1177
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to make the rotating snap_rotate GIF in the WhipperSnapPy tutorial render correctly in the Sphinx docs build (via nbsphinx/nbconvert), instead of degrading to a text/plain representation.
Changes:
- Updates the tutorial notebook to save the rotation GIF to a local filename.
- Adds Sphinx
conf.pymonkeypatches to includeimage/gifin nbsphinx output selection and rendering. - Patches nbconvert’s output extraction so
image/gifgets written as binary bytes to extracted files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tutorials/whippersnappy_tutorial.ipynb | Adjusts snap_rotate GIF output path intended to improve Sphinx accessibility. |
| doc/conf.py | Adds runtime patches for nbsphinx/nbconvert to select, render, and extract image/gif outputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR aims to make the rotating snap_rotate GIF in the WhipperSnapPy tutorial render correctly in the Sphinx docs build (via nbsphinx/nbconvert), instead of degrading to a text/plain representation.
Changes:
Updates the tutorial notebook to save the rotation GIF to a local filename.
Adds Sphinx conf.py monkeypatches to include image/gif in nbsphinx output selection and rendering.
Patches nbconvert’s output extraction so image/gif gets written as binary bytes to extracted files.