Skip to content

Follow up PR11 with SystemExit capture and roadmap guidance - #12

Merged
pramodbn27 merged 6 commits into
mainfrom
agent/pr11-systemexit-followup
Aug 9, 2026
Merged

Follow up PR11 with SystemExit capture and roadmap guidance#12
pramodbn27 merged 6 commits into
mainfrom
agent/pr11-systemexit-followup

Conversation

@pramodbn27

Copy link
Copy Markdown
Contributor

What changed

This packages the current PR11 follow-up into a small commit series.

  • captures non-zero SystemExit from the agentic-chaos adapter so failed script exits are reported as crashes
  • adds feature-completion expectations to maintainer docs
  • expands roadmap dependency and definition-of-done guidance
  • records a stronger roadmap warning around chaos.run_experiment script allowlisting and security posture

Why

Some experiment scripts fail by calling sys.exit(code) rather than raising another exception type. Without this change, those failures were not being captured in the adapter's crash path.

Impact

chaos.run_experiment now treats non-zero SystemExit the same way as other crash conditions, which improves failure reporting for user scripts.

Root cause

The adapter caught generic exceptions but let non-zero SystemExit bypass the crash-recording path.

Validation

  • UV_CACHE_DIR=/tmp/uv-cache uv run pytest

@pramodbn27 pramodbn27 self-assigned this Aug 9, 2026
@pramodbn27
pramodbn27 marked this pull request as ready for review August 9, 2026 04:57
@pramodbn27
pramodbn27 requested a review from a team as a code owner August 9, 2026 04:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92c3041d0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/deep_agentic_core_mcp/adapters/agentic_chaos.py
@pramodbn27
pramodbn27 merged commit 9895657 into main Aug 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants