Add SWOT satellite geometry support to DDR routing#161
Closed
taddyb wants to merge 2 commits intoDeepGroundwater:masterfrom
Closed
Add SWOT satellite geometry support to DDR routing#161taddyb wants to merge 2 commits intoDeepGroundwater:masterfrom
taddyb wants to merge 2 commits intoDeepGroundwater:masterfrom
Conversation
Collaborator
Author
|
Closing since experiments didn't net a positive change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mmc.py) to blend SWOT/Lynker observed geometry with derived values, handling partial NaN coverageChanges
references/geo_io/build_swot_geometry.py(new): Pipeline to build SWOT geometry NetCDF from EIV fits + MERIT-SWORD crosswalk for North American PFAF regionssrc/ddr/routing/mmc.py: New_apply_data_override()for 3-case blending (MERIT-only, full Lynker, partial SWOT); refactored_get_trapezoid_velocity()to derive width/slope from hydraulic geometry power law with data overridesrc/ddr/routing/torch_mc.py: Updated to pass new geometry tensors through the routing interfacesrc/ddr/geodatazoo/merit.py: Extended MERIT data loader for SWOT geometry fieldssrc/ddr/validation/configs.py: New config fields for SWOT geometry pathsscripts/train.py: Minor update for new config fieldstests/: Updated routing and config tests for new interfaceTest plan
tests/routing/test_mmc.pyandtests/routing/test_utils.pytests/validation/test_configs.pybuild_swot_geometry.pyproduces valid NetCDF with sample EIV/crosswalk data🤖 Generated with Claude Code