Revert to v0.5.1 baseline with Leopold & Maddock physics#166
Merged
taddyb merged 4 commits intoDeepGroundwater:masterfrom Mar 14, 2026
Merged
Revert to v0.5.1 baseline with Leopold & Maddock physics#166taddyb merged 4 commits intoDeepGroundwater:masterfrom
taddyb merged 4 commits intoDeepGroundwater:masterfrom
Conversation
Collaborator
Author
|
results from MERIT train/test |
…anup, and autograd fix - Keep l1_loss (MAE) over mse_loss - Keep CUDA memory cleanup block after each mini-batch - Apply in-place autograd fix: use intermediate `initial` tensor for scatter_add before clamp Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Lynker hydrofabric performance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
top_widthandside_slopeper-timestep fromp_spatial * depth^q_spatialinstead of learning them independently. Adds_apply_data_override()for Lynker/partial-coverage blendingp_spatialreplacestop_width/side_slopeas a learnable KAN output (width coefficient, log-space[1, 200])scatter_add→clampno longer double-writes to output tensordel+empty_cache()after each mini-batchTest plan
pytest tests/ --ignore=tests/references)scripts/train_and_test.pywithmerit_training_config.yaml(MERIT path: power-law derived geometry)scripts/train_and_test.pywithlynker_train_and_test_config.yaml(Lynker path: data override)p_spatial→ routing → loss🤖 Generated with Claude Code