Open
Conversation
… creation - Updated `Http2RemoteTransport` to utilize a builder pattern, enhancing flexibility in specifying transport targets (by name, ID, or hierarchical path). - Introduced `TransportTarget` enum to clearly define the target type for remote actors. - Refactored related code in `ActorSystem` to align with the new transport creation method, improving readability and maintainability. - Enhanced tests to validate the new builder functionality and ensure correct behavior across various transport scenarios.
- Removed unused imports and refactored actor service references in `__init__.py` for better readability. - Consolidated actor service registration in `actor_system` to enhance clarity and maintainability. - Streamlined the `Remote` API in `router.py` by introducing a helper method for chunk building, reducing code duplication. - Updated `RustSchedulerBase` and its subclasses to improve worker selection logic and enhance code organization. - Refactored `StorageManager` to simplify bucket and topic management, improving locking mechanisms and resource handling. - Enhanced `SyncQueue` and `SyncQueueReader` to utilize a common synchronous execution method, improving code consistency. - Updated tests to reflect changes in actor proxy handling and ensure robust functionality across various scenarios.
- Removed unused imports and consolidated actor service references in `__init__.py` for improved readability. - Updated `_GlobalQueueAPI` and `_GlobalTopicAPI` to utilize direct queue and topic writing/reading functions, enhancing clarity. - Introduced new `protocol.py` and `proxy.py` files to encapsulate message serialization and actor proxy functionalities, streamlining the codebase. - Refactored `remote.py` to remove redundant methods and improve organization, focusing on actor lifecycle management. - Enhanced `service.py` with a dedicated `PythonActorService` for better actor creation handling and improved error management. - Updated documentation and tests to reflect changes in actor management and API structure, ensuring robust functionality.
- Streamlined the Python API documentation by reorganizing sections for clarity, including lifecycle management, actor definition, and usage examples. - Enhanced actor management details, including initialization, spawning, and resolution methods, to improve user understanding. - Updated examples to reflect new API structures and best practices, ensuring consistency and clarity in usage. - Removed outdated sections and consolidated information to provide a more cohesive and user-friendly documentation experience.
- Updated the `resolve` function to support typed proxies, allowing for direct method calls without needing to use `.as_type()` or `.as_any()`. - Improved documentation across multiple files to clarify the usage of `pul.resolve()` for both typed and untyped proxies, enhancing user understanding. - Refactored examples to demonstrate the new resolution capabilities and best practices for actor management. - Consolidated references to actor resolution methods in the API documentation, ensuring consistency and clarity for users transitioning from previous versions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)