4 refactor centralize game logic and constants#7
Merged
Conversation
- Create `src/config/gameConfig.ts` to house all game constants, formulas, and balancing values. - Create `src/types/game.ts` to centralize shared TypeScript interfaces and prevent circular dependencies. - Implement a unified `calculateCurrentIncome` helper function to standardize active and offline income logic. - Refactor `gameStore.ts` and UI components (PackOpening, Dimension, Upgrades, etc.) to consume centralized configuration. - Remove hardcoded values for pack requirements, upgrade costs, sell prices, and card generation weights.
Fix [FIX] Improve type safety and remove any casts Fixes #5
4 tasks
MrJacob12
had a problem deploying
to
github-pages
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 #5