Do not add defang- prefix to azure keyvault

[edwardrf]

https://github.com/DefangLabs/pulumi-defang/issues/207Do not add defang- prefix to azure keyvault

Linked Issues

DefangLabs/pulumi-defang#207

Checklist

• I have performed a self-review of my code
• I have added appropriate tests
• I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

Summary by CodeRabbit

• Chores
  • Updated Azure Key Vault naming convention. Vault name prefixes have been simplified to reflect the new naming standard.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fbe734bc-9e6d-4bb1-89bb-75a6015f2c82

📥 Commits

Reviewing files that changed from the base of the PR and between 3968770 and b5f2fb8.

📒 Files selected for processing (2)

• src/pkg/clouds/azure/keyvault/keyvault.go
• src/pkg/clouds/azure/keyvault/keyvault_test.go

---

📝 Walkthrough

Walkthrough

The Azure Key Vault name prefix is simplified from "defang-config-" to "config-" in the VaultName() function. The test expectation is updated correspondingly to validate the new prefix format.

Changes

Vault Name Prefix Simplification

Layer / File(s)	Summary
Core Implementation src/pkg/clouds/azure/keyvault/keyvault.go	VaultName() function prefix changed from "defang-config-" to "config-" when generating deterministic vault names.
Tests src/pkg/clouds/azure/keyvault/keyvault_test.go	TestVaultName assertion updated to expect the new "config-" prefix and error message adjusted accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• jordanstephens
• lionello

Poem

🐰 A vault name grows lean and trim,
From "defang-config-" to "config-" slim,
The prefix is lighter, the logic stays true,
A simple shortcut in azure's blue queue!

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch edw/azure-kv-no-defang-prefix

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

level=warning msg="The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2."
level=warning msg="Suggested new configuration:\nlinters:\n enable:\n - gomodguard_v2\n"
level=warning msg="[linters_context] running gomodguard failed: unable to read module file go.mod: current working directory must have a go.mod file: if you are not using go modules it is suggested to disable this linter"
level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}