minor: use django.conf.settings over dojo.settings everywhere#14434
Open
fopina wants to merge 2 commits intoDefectDojo:devfrom
Open
minor: use django.conf.settings over dojo.settings everywhere#14434fopina wants to merge 2 commits intoDefectDojo:devfrom
fopina wants to merge 2 commits intoDefectDojo:devfrom
Conversation
🔴 Risk threshold exceeded.This pull request modifies sensitive files (dojo/apps.py and dojo/reports/widgets.py); the scanner flagged these as configured codepath edits and notes that sensitive paths and allowed authors can be set in .dryrunsecurity.yaml. These findings are marked with a failing risk threshold but are non-blocking.
🔴 Configured Codepaths Edit in
|
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
🔴 Configured Codepaths Edit in dojo/reports/widgets.py (drs_3a61a761)
| Vulnerability | Configured Codepaths Edit |
|---|---|
| Description | Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml. |
We've notified @mtesauro.
All finding details can be found in the DryRun Security Dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was having issues when setting DJANGO_MODULE_SETTINGS to a custom module and noticed
dojo.settingswas imported directly in some placesdojo/wsgi.py)mainapp/wsgi.pyand it is currently hereapp.ready()to avoid triggering LazySettings evaluation at model import time