Conversation
Contributor
Author
|
Needs tests still, but is this on the right track? |
johnmaguire
reviewed
Nov 7, 2025
client.go
Outdated
| Org ConfigOrg | ||
| Network ConfigNetwork | ||
| Host ConfigHost | ||
| EndpointOIDC ConfigEndpointOIDC |
johnmaguire
reviewed
Nov 7, 2025
client.go
Outdated
| } | ||
|
|
||
| type ConfigEndpointOIDC struct { | ||
| Email *string |
johnmaguire
reviewed
Nov 7, 2025
message/message.go
Outdated
| Organization HostOrgMetadata `json:"organization"` | ||
| Network HostNetworkMetadata `json:"network"` | ||
| Host HostHostMetadata `json:"host"` | ||
| EndpointOIDCMeta *HostEndpointOIDCMetadata `json:"endpointOIDC,omitempty"` |
Member
There was a problem hiding this comment.
don't need omitempty on this side (same for DoUpdate)
Member
|
looks good |
Contributor
Author
|
Doh I put it at the wrong level, thanks. |
johnmaguire
previously approved these changes
Nov 7, 2025
| assert.Equal(t, hostID, meta.Host.ID) | ||
| assert.Equal(t, hostName, meta.Host.Name) | ||
| assert.Equal(t, hostIP, meta.Host.IPAddress) | ||
| assert.Equal(t, oidcEmail, meta.EndpointOIDC.Email) |
Member
There was a problem hiding this comment.
for completeness sake, you could add a assert.Nil(t, meta.EndpointOIDC) to an existing test. dubious value maybe
johnmaguire
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the email that is exposed in https://github.com/DefinedNet/api/pull/1887 and passes it along to dnclient in the enroll and doUpdate responses.