Simplify response types in messages with generics#31
Merged
johnmaguire merged 4 commits intomainfrom Nov 12, 2025
Merged
Conversation
johnmaguire
force-pushed
the
simplify-types
branch
from
7ccfb4a to
364a711
Compare
johnmaguire
commented
Nov 12, 2025
johnmaguire
force-pushed
the
simplify-types
branch
from
a098977 to
04acfa1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adding the downloads endpoint I noticed we can use generics for the common
{Data, Errors}paradigm in our API. Updated the existing code and filing this PR to build on.This file could be further improved by splitting out some components into separate files: