Conversation
johnmaguire
force-pushed
the
downloads-endpoint
branch
from
98ab8e8 to
1e938ce
Compare
jasikpark
reviewed
Nov 17, 2025
Contributor
jasikpark
left a comment
jasikpark
left a comment
There was a problem hiding this comment.
lgtm, can you update the PR description now that tests are added?
| return []byte(downloadsResponse) | ||
| }) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second) |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): You can use https://pkg.go.dev/testing#T.Context now, I think? should allow tying the context to the runtime of the test.
Member
Author
There was a problem hiding this comment.
i'd approve a pr to update the repo with this pattern, but will leave this as-is to match the rest of the file.
jasikpark
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.