Setup up flutter tests, minimal starter tests by jasikpark · Pull Request #324 · DefinedNet/mobile_nebula

jasikpark · 2026-01-30T18:53:23Z

Adds some initial tests, focused on the changes in #323. We don't really have any Flutter tests at the moment, so the main goal is just getting us a baseline of tests to start improving from.

Adds some functional tests
https://docs.flutter.dev/cookbook/testing/widget/introduction
Adds "golden" tests, which are checked-in screenshots that are diffed for changes.
https://api.flutter.dev/flutter/flutter_test/GoldenFileComparator-class.html This has issues w/ snapshots differing locally vs CI, so I'll leave this for a followup PR.

jasikpark · 2026-01-30T22:48:55Z

hell yeah, finally got the tests running in CI, just gotta fix some of the golden tests and whatnot...

jasikpark · 2026-01-30T23:01:39Z

~~just deleted the failing tests 💀 I figure it'd be good to get a minimal non-flaky set in, and then build from there 🏗️~~

ok, I think I got things fixed? We'll certainly find out...

jasikpark · 2026-01-31T00:39:24Z

bruh

jasikpark · 2026-01-31T00:41:37Z

~~TODO for @jasikpark on monday: implement https://fluttergoldens.com/running-goldens/running-on-github/ to see failure screenshots~~

This commit adds a complete test suite covering the UI modernization changes introduced in PR #323, including: - SiteItem widget tests (21 tests) - Site name and badge rendering - Connection status display - Error state handling - Switch behavior and enable/disable logic - Typography and theming - SettingsScreen tests (13 tests) - All settings sections rendering - Debug functionality (moved from MainScreen) - Debug site constants validation - Settings interactions - Utils service tests (14 tests) - popError dialog functionality - Error message display - Stack trace inclusion - Multiple error dialogs - Text size calculations - Item count formatting - Theme tests (15 tests) - Light and dark theme generation - Badge theme configuration (new in PR #323) - Custom color application - Medium and high contrast variants - Theme consistency Test infrastructure: - test_helpers.dart with MockSite and createTestApp utilities - Comprehensive README.md with usage examples and best practices - All 63 tests passing These tests validate the key changes in PR #323: ✓ Modernized SiteItem UI with integrated toggle and details button ✓ Badge component for managed sites ✓ Material theme consistency across iOS widgets ✓ Debug functionality moved to SettingsScreen ✓ Utils.popError refactored to use global navigator key

This workflow runs on every push and pull request to main/master: - Sets up Flutter 3.29.0 - Runs flutter analyze for static analysis - Runs all 63 tests with coverage - Uploads coverage report as artifact (downloadable from Actions tab) The workflow ensures that all tests pass before merging PRs.

Ignore test coverage files and directories: - coverage/ - Generated coverage reports - test/.test_coverage.dart - Test coverage helper file - *.coverage - Coverage data files This prevents test artifacts from being committed to the repository.

- Add missing imports for debug constants in settings_screen_test.dart - Mark release mode test as skipped in debug mode with skip parameter - Rename test to accurately reflect what it verifies - Add super.dispose() call in MockSite to ensure proper cleanup

- Add concise Testing section to README.md with essential test commands - Remove test/README.md to reduce documentation duplication - Keep only the how-to-run information, under 10 lines as requested

Replace smoke tests that only verify widget existence with behavioral tests that validate actual user interactions. Tests now verify switch interactivity, conditional rendering logic, and UI responsiveness. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Adds comprehensive golden (snapshot) tests for MainScreen and SiteDetailScreen to catch visual regressions. Tests cover various states including connected/disconnected sites, error states, managed sites, and edge cases like long names. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

… 13 pro

Sets tester.view.devicePixelRatio = 1.0 in each golden test to prevent fractional pixel calculations that cause anti-aliasing artifacts and minor pixel shifts in golden file comparisons. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

…nconsistencies

nbrownus · 2026-02-12T22:10:04Z

README.md

+flutter test --coverage
+```
+
+Run golden tests (update with `--update-goldens` flag):


Probably should remove this since we aren't doing goldens yet

nbrownus · 2026-02-12T22:13:06Z

pubspec.lock

@@ -89,6 +89,14 @@ packages:
      url: "https://pub.dev"


Has this been rebased on main since the flutter upgrade? If so, might want to run a flutter pub get, seems there is some cruft here.

nbrownus · 2026-02-12T22:14:00Z

test/components/site_item_test.dart

+import '../test_helpers.dart';
+
+/// Helper to find text within RichText widgets
+Finder findRichText(String text) {


Does this belong in test/test_helpers.dart?

Base automatically changed from sites to main January 30, 2026 19:13

jasikpark force-pushed the pr-323-tests branch from 201c341 to 55c171b Compare January 30, 2026 19:25

jasikpark linked an issue Jan 30, 2026 that may be closed by this pull request

Add Flutter tests #328

Open

jasikpark marked this pull request as ready for review January 30, 2026 23:01

jasikpark requested a review from nbrownus January 30, 2026 23:01

jasikpark force-pushed the pr-323-tests branch from 77e5fa4 to 79b26af Compare January 30, 2026 23:27

jasikpark force-pushed the pr-323-tests branch 3 times, most recently from 954a236 to 8b74ec4 Compare February 10, 2026 16:50

jasikpark and others added 17 commits February 10, 2026 10:56

Remove unused imports

ee951c9

Don't track ios/Flutter/ephemeral

832d093

Update pubspec.lock

cacca71

Move test documentation to main README

d565511

- Add concise Testing section to README.md with essential test commands - Remove test/README.md to reduce documentation duplication - Keep only the how-to-run information, under 10 lines as requested

Adjust assertions for clarity

f70b1d9

Fix lints in test files

94f5e9d

Don't fail flutter analyze on info or warning lints

c574a46

Disable flutter analyze in CI

aa80215

Use build pipeline from smoke.yml

98d268e

moar fix

14d7214

Match naming and casing from other flutter jobs

0a35fd7

jasikpark and others added 11 commits February 10, 2026 10:56

Rename flutter test workflow file

baa1894

Generate artifacts for ios

17da612

Run on macos 26

b3d6615

Mention that this is the iOS flutter test

8c1a4d8

Remove useless test

8504054

Re-add failing golden tests w/ explicit screen size config for iphone…

0b4ab84

… 13 pro

Try setting screen size per-test to see if that fixes CI v.s. local i…

46c49e8

…nconsistencies

Remove golden tests to make first testing PR easy to review and merge

1495ef5

Revert changes to SiteDetailScreen.dart

7355ee7

Oops updated SiteDetailScreen.dart when it was renamed

742c33f

jasikpark force-pushed the pr-323-tests branch from 8b74ec4 to 742c33f Compare February 10, 2026 16:58

jasikpark added 8 commits February 10, 2026 10:59

format

4aecd09

Simplify flutter analyze recc command

e8009ce

Update fluttertest.yml

1c42070

Fix imports

89da846

Fix imports

764e3da

Fix tests for the rich text widget change

0ff8b0e

Fix flutter test job title

8605c1d

Fix artifact unique names

7b8fc33

jasikpark changed the title ~~Add test suite for PR #323~~ Setup up flutter tests, minimal starter tests Feb 10, 2026

Add gradle cache

e69e0a3

nbrownus reviewed Feb 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup up flutter tests, minimal starter tests#324

Setup up flutter tests, minimal starter tests#324
jasikpark wants to merge 37 commits intomainfrom
pr-323-tests

jasikpark commented Jan 30, 2026 •

edited

Loading

Uh oh!

jasikpark commented Jan 30, 2026

Uh oh!

jasikpark commented Jan 30, 2026 •

edited

Loading

Uh oh!

jasikpark commented Jan 31, 2026

Uh oh!

jasikpark commented Jan 31, 2026 •

edited

Loading

Uh oh!

nbrownus Feb 12, 2026

Uh oh!

nbrownus Feb 12, 2026

Uh oh!

nbrownus Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jasikpark commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasikpark commented Jan 30, 2026

Uh oh!

jasikpark commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasikpark commented Jan 31, 2026

Uh oh!

jasikpark commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nbrownus Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

nbrownus Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

nbrownus Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jasikpark commented Jan 30, 2026 •

edited

Loading

jasikpark commented Jan 30, 2026 •

edited

Loading

jasikpark commented Jan 31, 2026 •

edited

Loading