IPAndPort.fromString factory method which does validation#348
Merged
Conversation
JackDoan
previously approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a starting point for yaml import. Currently targeting yaml ->
Siteconversion to occur in dart land. Other parts of theSitemodel will eventually get afromYamlfactory, static helper method, or in the case of simple objects likeIPAndPort,fromStringcan be sufficient.We currently only have 1 caller for
IPAndPort.fromString. Getting anIPAndPortinto a site config should have passed through the currentipValidatorordnsValidatorwhich is more or less identical to the new validationIPAndPort.fromStringis doing. I don't think we will break site rendering for anyone as a result.