CI: make the Windows build a real gate - #6
Merged
Conversation
The build job has never actually run. Two things kept it down, and the job carried continue-on-error, so every run still reported success and the badge only ever meant "static checks passed". 1. `ref: 3725be3` is a SHORT SHA. actions/checkout only treats a ref as a commit when it is the full 40 characters; anything shorter resolves as a branch or tag, so it fetched refs/heads/3725be3* , matched nothing and failed. Pinned to the full SHA. 2. The PicoGK fork was private, so the checkout needed PICOGK_TOKEN. It is public now, so the default GITHUB_TOKEN is enough and the token line is gone. That is also what unblocks Dependabot and fork PRs, which are never handed repo secrets. With both fixed the job can stand on its own, so continue-on-error comes off and a broken build now fails CI. The guard step keeps its early, readable failure but is an ::error rather than a ::notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Kevo <kevofehr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build (windows, .NET 9)job has never actually run. It failed on every run, but the job carriedcontinue-on-error: true, so the workflow still reported success and the CI badge only ever meant static checks passed.Two causes, both fixed here:
ref: 3725be3is a short SHA.actions/checkoutonly treats a ref as a commit when it is the full 40 characters; anything shorter is resolved as a branch or tag name. The log shows it fetching+refs/heads/3725be3*:..., matching nothing, and failing with a bare exit code 1. Now pinned to the full SHA3725be3aa88af97b12a4a531a4a93be0d8e1eeb6.secrets.PICOGK_TOKEN. It is public now, so the defaultGITHUB_TOKENsuffices and thetoken:line is gone. This is also what unblocks Dependabot and fork PRs, which are never handed repo secrets.With both fixed the job can stand on its own, so
continue-on-errorcomes off and a broken build fails CI from now on. The guard step keeps its early, readable failure, upgraded from::noticeto::errorwith a message that matches reality.This PR is the test. A green
build (windows, .NET 9)check here is the first time that job has ever passed, and is the only evidence that removingcontinue-on-erroris safe.Follow-up, not in this PR: the four open Dependabot PRs (#1, #2, #3, #5) are all red for this same reason, not on their own merits. They want a rebase once this lands.
🤖 Generated with Claude Code