Gridedit 2292 eliminate internal element boundaries from invalid cells polygons#536
Open
BillSenior wants to merge 14 commits into
Open
Gridedit 2292 eliminate internal element boundaries from invalid cells polygons#536BillSenior wants to merge 14 commits into
BillSenior wants to merge 14 commits into
Conversation
…ns that are covering the same patch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve how Mesh2D “invalid cell / inner boundary” polygons are maintained after mesh face deletions (to eliminate internal boundaries from the resulting polygon sets), and removes some leftover diagnostic output in VTK export.
Changes:
- Remove
unsavedElementsdebug counting/printing fromSaveVtkhelpers. - Extend
Mesh2D::ComputeBoundaryPolygonswith an option to skipAdministrate(). - Add
Mesh2D::ReconstructInvalidCellsPolygon()and invoke it fromUpdateFaceInformation().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| libs/MeshKernel/src/Utilities/Utilities.cpp | Removes element-count debug bookkeeping/std::cout output from VTK export. |
| libs/MeshKernel/src/Mesh2D.cpp | Adds optional administration in boundary polygon computation; introduces and calls invalid-cell polygon reconstruction after face updates. |
| libs/MeshKernel/include/MeshKernel/Mesh2D.hpp | Updates public API signature for ComputeBoundaryPolygons, adds declaration/docs for ReconstructInvalidCellsPolygon. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1579
to
1583
| if (meshBoundaryPolygon.size() > numNodesFirstTail) | ||
| { | ||
| std::reverse(meshBoundaryPolygon.begin() + numNodesFirstTail, meshBoundaryPolygon.end()); | ||
| meshBoundaryPolygon.push_back(meshBoundaryPolygon.front()); | ||
| } |
Comment on lines
+2211
to
+2215
| if (polygons.GetNumPolygons() <= 1) | ||
| { | ||
| // There are no interior boundary polygons | ||
| return; | ||
| } |
RStolkerDeltares
approved these changes
Jul 16, 2026
| if (polygons.GetNumPolygons() <= 1) | ||
| { | ||
| // There are no interior boundary polygons | ||
| return; |
Contributor
There was a problem hiding this comment.
Shouldn't m_invalidCellPolygons be cleared?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.