Add support for discharge scaling in drainage package#1012
Draft
Add support for discharge scaling in drainage package#1012
Conversation
MODFLOW 6 has changed a number of options in the IMS package (since quite some time). * This adds support for outer_csvfile and inner_csvfile instead of csv_output. * This simplifies the no_ptc option: instead of a bool and a possible additional entry, just the entry is required. (In the IMS file, NO_PTC is equal to NO_PCT ALL, i.e. the ALL is an assumed default value.) * This also adds support for the adaptive time stepping entry ats_outer_maximum_fraction. All the deprecated solution keyword arguments have been removed from the examples.
Contributor
Author
|
Something to consider when dealing with the auxiliary arrays: MODFLOW 6 has no info in the .dat/.bin files to see which column is which. Instead, (I'm pretty sure) the meaning of the columns depends on the order of the auxiliary entry in the options block. This means it's crucial to coordinate the order of the variables when converting to a dictionary of arrays with the auxiliary entry written in the options block. Otherwise you end up with MF6 interpreting the concentration as the factor or vice versa. |
|
Manangka
force-pushed
the
master
branch
3 times, most recently
from
05ac3f7 to
5694d30
Compare
Manangka
force-pushed
the
master
branch
2 times, most recently
from
ef47289 to
b33942f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Still a draft, this adds the drainage discharge scaling depth.
This is a rather pragmatic approach. We're currently only using the auxiliary variables for concentration, which are treated separately. The
_auxiliary_data = {"concentration": "species"}cannot be meaningfully used, since this specificscaling_depthdoes not contain any additional dimensions.Adding it to
period_dataensures that it is written to the data files, but since it's optional, the presences must then be checked inget_period_names.I think the name "scaling_depth" is relatively clear. "discharge_scaling_depth" is maybe more complete, but is a bit of a mouthful.
We don't support auxiliary variables, I'm not sure if it's worth adding general support. Most packages support a multiplication factor auxiliary variable, which we really don't care for.