Wq add anihfb

[Manangka]

In GitLab by @jdelsman on Nov 17, 2022, 22:34

Add support for imod-wq ANI and HFB packages

• write anifile with relative paths to runfile
• write associated .arr files
• write HFB file with relative path in runfile
• tests
• linting

[Manangka]

In GitLab by @jdelsman on Nov 17, 2022, 22:34

requested review from @Huite

[Manangka]

In GitLab by @jdelsman on Nov 17, 2022, 22:35

added 8 commits

• 6ecbf39...319cea1 - 4 commits from branch master
• 9842e27 - add ani hfb support for wq
• ca3945d - store relative path in render to use in save
• d6c83c6 - fix constant or write arr
• f6bfd6d - hfb id changed to hfb6 as reqd by imodwq

Compare with previous version

[Manangka]

In GitLab by @JoerivanEngelen on Nov 29, 2022, 16:07

On the linting: I see the linting crashes on isort.

You can install isort in your conda environment with pip install isort, then run isort in your terminal.

Alternatively, you can also run tox -e format locally, which does the same (requires tox installed in your base environment)

[Manangka]

In GitLab by @jdelsman on Nov 29, 2022, 16:57

added 6 commits

• 7d962fc - add ani hfb support for wq
• 4bdd4a1 - store relative path in render to use in save
• 6574710 - fix constant or write arr
• 6ecbf39 - hfb id changed to hfb6 as reqd by imodwq
• 3d32903 - isort
• cd10d2e - isort

Compare with previous version

[Manangka]

In GitLab by @JoerivanEngelen on Nov 29, 2022, 17:45

added 2 commits

• 03613a0 - 1 commit from branch master
• ed4a922 - Merge branch 'master' into wq_add_anihfb

Compare with previous version

[Manangka]

In GitLab by @jdelsman on Nov 30, 2022, 09:48

added 1 commit

• da14c10 - lint cleanup

Compare with previous version

[Manangka]

In GitLab by @jdelsman on Nov 30, 2022, 09:57

marked this merge request as ready

[Manangka]

In GitLab by @jdelsman on Nov 30, 2022, 10:04

marked this merge request as draft

[Manangka]

In GitLab by @jdelsman on Dec 1, 2022, 09:16

@Huite , @JoerivanEngelen : with regards to testing, any ideas on that? Because of the imod-wq implementation, the runfile refers to a separate ani (or hfb) file. That is easily tested of course, but how to test the generated ani (of hfb) file?

[Manangka]

In GitLab by @jdelsman on Dec 2, 2022, 13:33

added 1 commit

• 21438f9 - test render

Compare with previous version

[Manangka]

In GitLab by @jdelsman on Dec 2, 2022, 15:50

marked the checklist item tests as completed

[Manangka]

In GitLab by @jdelsman on Dec 2, 2022, 15:50

marked this merge request as ready

[sonarqubecloud]

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud