Draft: Resolve "imod.visualize.cross_section does not support quasi 3D layering"

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:06

Closes #329

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:09

added 1 commit

• 03053b9 - fix for quasi 3d layering

Compare with previous version

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:09

An initial fix for issue #329. Works for my use-case, but haven't thoroughly tested...

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:10

requested review from @JoerivanEngelen

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:10

requested review from @Huite

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:10

removed review request for @JoerivanEngelen

[Manangka]

In GitLab by @jdelsman on Feb 9, 2023, 18:16

added 1 commit

• 107c942 - reverted inclusion of colorbar

Compare with previous version

[Manangka]

In GitLab by @JoerivanEngelen on Feb 17, 2023, 10:28

I think this merge request is also related to https://gitlab.com/deltares/imod/imod-python/-/issues/175, right?

[Manangka]

In GitLab by @JoerivanEngelen on May 26, 2023, 10:22

added 73 commits

• 107c942...8ddbfb3 - 72 commits from branch master
• ec2440c - fix for quasi 3d layering

Compare with previous version

[Manangka]

In GitLab by @JoerivanEngelen on May 26, 2023, 10:30

Thanks for the fixes, these seem to fix some obvious mistakes in the code. I see our tests currently cover the visualization very poorly; so it is hard to tell if these fixes actually work.
Asking you to add tests will be quite the burden to you, as the test bench is not in a good shape for the visualization module anyway.

I think we first need to add some unit tests covering of _meshcoords, to see if this actually does the right thing.

For now, I at least rebased this branch, to make sure it is still up to date.

[Manangka]

In GitLab by @jdelsman on Sep 22, 2023, 16:20

added 3 commits

• 03053b9 - fix for quasi 3d layering
• 107c942 - reverted inclusion of colorbar
• 00f01b6 - Merge branch...

Compare with previous version

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud