Skip to content

Feature/font improvements #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeluxeAlonso merged 5 commits into from
Apr 30, 2025
Merged

Feature/font improvements #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf23f8f
Updates CustomFooterView
DeluxeAlonso Apr 30, 2025
7868ef0
Updates JobDetailSectionView
DeluxeAlonso Apr 30, 2025
78b8dcc
Updates JobDetailHeaderView
DeluxeAlonso Apr 30, 2025
1578d54
Merge branch 'development' of https://github.com/DeluxeAlonso/GithubJ…
DeluxeAlonso Apr 30, 2025
de4f000
Updates ThemeSelectionSectionHeaderView
DeluxeAlonso Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GithubJobs/Helpers/ViewComponents/CustomFooterView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ final class CustomFooterView: UIView {
label.textAlignment = .center
label.minimumScaleFactor = 0.5
label.adjustsFontSizeToFitWidth = true
label.font = FontHelper.dynamic(.body)
label.font = FontHelper.Dynamic.body
label.adjustsFontForContentSizeCategory = true
label.translatesAutoresizingMaskIntoConstraints = false
return label
Expand Down
2 changes: 1 addition & 1 deletion GithubJobs/Scenes/JobDetail/ViewComponents/Header/JobDetailHeaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ final class JobDetailHeaderView: UIView {
label.setContentHuggingPriority(.required, for: .vertical)
label.setContentCompressionResistancePriority(.required, for: .vertical)
label.numberOfLines = 0
label.font = FontHelper.dynamic(.body)
label.font = FontHelper.Dynamic.body
label.adjustsFontForContentSizeCategory = true
label.translatesAutoresizingMaskIntoConstraints = false
return label
Expand Down
2 changes: 1 addition & 1 deletion GithubJobs/Scenes/JobDetail/ViewComponents/Section/JobDetailSectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ final class JobDetailSectionView: UIView {
label.textAlignment = .center
label.textColor = .black
label.backgroundColor = .systemTeal
label.font = FontHelper.dynamic(.body)
label.font = FontHelper.Dynamic.body
label.adjustsFontForContentSizeCategory = true

return label
Expand Down
2 changes: 1 addition & 1 deletion ...bJobs/Scenes/Settings/ThemeSelection/ViewComponents/ThemeSelectionSectionHeaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ final class ThemeSelectionSectionHeaderView: UICollectionReusableView {
private lazy var titleLabel: UILabel = {
let label = UILabel()
label.textColor = .systemGray
label.font = .preferredFont(forTextStyle: .footnote)
label.font = FontHelper.Dynamic.footnote

label.translatesAutoresizingMaskIntoConstraints = false

Expand Down