Draft
Conversation
Owner
|
This is awesome! I applaud you for putting up with my horrible codebase 😜
There could be a popup when sharing multiple entries with a toggle for images, but that seems like it could be annoying. I would be in favor of defaulting to always sharing images. The rationale being that the user could remove the images after the fact if they really wanted/needed to. For example, when sharing to a messaging or email app. Some thoughts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently there is an ability to share a single day entry. I was looking to share multiple days.
For my use case, I only needed to share text, but if there's a need, I'd be happy to update the code to share images too. Maybe with an option presented whether to share with images or text only. Not sure what's the ideal UX here.