Skip to content

Add a Gear column showing profession tool and accessory slots#139

Open
bifferz wants to merge 3 commits intoDennisRas:mainfrom
bifferz:profession_gear_icons
Open

Add a Gear column showing profession tool and accessory slots#139
bifferz wants to merge 3 commits intoDennisRas:mainfrom
bifferz:profession_gear_icons

Conversation

@bifferz
Copy link
Copy Markdown

@bifferz bifferz commented Apr 4, 2026

I've been thinking it'd be nice to see profession gear at a glance across my many alts in the table, so I put together a Gear column that shows the tool and accessory slots for each profession row.

Each slot renders as an icon with a quality color border and a rank star overlay in the top-left corner. Hovering shows the item tooltip. Unscanned characters show dimmed empty slots so you can tell the difference between "no gear" and "not checked yet."

A few things I worked through along the way:

  • Gear is filtered to only show on the expansion row it actually belongs to — so War Within enchanting gear won't bleed onto a Midnight Enchanting row
  • The profession to slot group mapping uses the equipped tool's item subtype rather than index order, which turned out to be unreliable
  • Items not yet in the client cache get a pending state and rescan automatically when the data loads

I also bumped TABLE_ROW_HEIGHT from 24 to 30 — the icons needed a bit more breathing room and it felt like an improvement overall, but happy to revert that if you'd prefer to keep the denser layout.

Here's a quick preview after my changes
image

I also just saw on dev that you've got sorting working in a different way. I implemented a "gear score" and sorting here, but that can be scrapped for your implementation obviously. Also, sorry for the messy commit history we can squash those down. Did some clean up, updated for your sorting work merged to main.

Cheers!

@bifferz bifferz force-pushed the profession_gear_icons branch from 9a28364 to 109590f Compare April 27, 2026 13:38
@bifferz
Copy link
Copy Markdown
Author

bifferz commented Apr 27, 2026

Rebased onto your sorting refactor on main. The Gear column is now wired into Table.lua framework: renderCell and sorting.compare. Moved the icon rendering from Interface.lua to Table.lua since CreateTableFrame is there now.

Also fixed a few small things while rebasing (invalid atlas with some crafting ranks, tootlip var named poorly). The commit history is cleaner after the force push, no reason to really keep it lookin ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant