Add a Gear column showing profession tool and accessory slots#139
Open
bifferz wants to merge 3 commits intoDennisRas:mainfrom
Open
Add a Gear column showing profession tool and accessory slots#139bifferz wants to merge 3 commits intoDennisRas:mainfrom
bifferz wants to merge 3 commits intoDennisRas:mainfrom
Conversation
9a28364 to
109590f
Compare
Author
|
Rebased onto your sorting refactor on main. The Gear column is now wired into Table.lua framework: Also fixed a few small things while rebasing (invalid atlas with some crafting ranks, tootlip var named poorly). The commit history is cleaner after the force push, no reason to really keep it lookin ugly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been thinking it'd be nice to see profession gear at a glance across my many alts in the table, so I put together a Gear column that shows the tool and accessory slots for each profession row.
Each slot renders as an icon with a quality color border and a rank star overlay in the top-left corner. Hovering shows the item tooltip. Unscanned characters show dimmed empty slots so you can tell the difference between "no gear" and "not checked yet."
A few things I worked through along the way:
I also bumped
TABLE_ROW_HEIGHTfrom 24 to 30 — the icons needed a bit more breathing room and it felt like an improvement overall, but happy to revert that if you'd prefer to keep the denser layout.Here's a quick preview after my changes

I also just saw on dev that you've got sorting working in a different way. I implemented a "gear score" and sorting here, but that can be scrapped for your implementation obviously. Also, sorry for the messy commit history we can squash those down.Did some clean up, updated for your sorting work merged to main.Cheers!