feat: add OWASP analysis fields to FindingAudit component#1553
Open
fahedouch wants to merge 1 commit into
Open
feat: add OWASP analysis fields to FindingAudit component#1553fahedouch wants to merge 1 commit into
fahedouch wants to merge 1 commit into
Conversation
Signed-off-by: Fahed Dorgaa <fahed.dorgaa@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds display of OWASP Risk Rating vector, score, and analysis source fields to the Finding Audit view, along with corresponding i18n keys across all supported locales.
Changes:
- Added three new read-only form fields (OWASP RR Vector, OWASP RR Score, Analysis Source) to the Finding Audit view, populated from the analysis object.
- Added new data properties and population logic in the
populateAnalysisDatamethod. - Added new i18n keys (
owasp_rr_vector,owasp_rr_score,analysis_source) across all locale files, with English translations and null placeholders for other languages.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/portfolio/projects/FindingAudit.vue | Adds UI fields and data bindings for OWASP RR vector/score and analysis source. |
| src/i18n/locales/en.json | Adds English translations for the new i18n keys. |
| src/i18n/locales/de.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/es.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/fr.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/hi.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/it.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/ja.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/pl.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/pt-BR.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/pt.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/ru.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/uk-UA.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/zh-TW.json | Adds placeholder (null) entries for the new keys. |
| src/i18n/locales/zh.json | Adds placeholder (null) entries for the new keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+143
to
+145
| <b-form-group | ||
| v-if="owaspScore" | ||
| id="fieldset-owasp-score" |
Comment on lines
+495
to
+503
| if (Object.prototype.hasOwnProperty.call(analysis, 'owaspVector')) { | ||
| this.owaspVector = analysis.owaspVector; | ||
| } | ||
| if (Object.prototype.hasOwnProperty.call(analysis, 'owaspScore')) { | ||
| this.owaspScore = analysis.owaspScore; | ||
| } | ||
| if (Object.prototype.hasOwnProperty.call(analysis, 'source')) { | ||
| this.analysisSource = analysis.source; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same change as DependencyTrack/hyades-frontend#465, moved here since v5 dev is on this repo now. Adds the OWASP RR vector/score and the analysis source to the finding audit
panel (read-only), goes together with the backend PR DependencyTrack/dependency-track#6210.
Addressed Issue
Additional Details
Checklist