fix(install): accept legacy archives without cbm-integrations.json - #1505
Draft
michaelxer wants to merge 2 commits into
Draft
fix(install): accept legacy archives without cbm-integrations.json#1505michaelxer wants to merge 2 commits into
michaelxer wants to merge 2 commits into
Conversation
Published v0.9.0 Windows/Unix release archives still ship the four-file core layout and omit cbm-integrations.json. Main install.ps1/install.sh required the five-file layout after runtime assets were externalized, so raw.githubusercontent.com installers fail on current latest downloads with "archive must contain exactly one cbm-integrations.json". Accept either the legacy four-file core set or the current five-file set (and the matching UI +1 pack). package-release.sh still ships the integration manifest for new builds. Add a focused layout-compat test. Fixes DeusData#1499 Signed-off-by: michaelxer <michaelxer@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
The install scripts now accept both the legacy four-file core layout and the current five-file layout. Update the smoke fixture static assertions to match EXPECTED_CORE_COUNT rather than hard-coded EXPECTED_MEMBER_COUNT=5/6 so Step 0h no longer fails the dual-accept installer change. Signed-off-by: michaelxer <michaelxer@users.noreply.github.com>
michaelxer
force-pushed
the
michaelxer/fix-install-archive-layout-compat-1499-20260809
branch
from
August 9, 2026 02:26
87436ee to
0391040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1499.
Published v0.9.0 Windows/Unix release archives still ship the four-file core layout and omit
cbm-integrations.json. After runtime assets were externalized onmain,install.ps1/install.shfromraw.githubusercontent.com/.../mainrequire the five-file layout, so installers fail against currentlatestdownloads with:I reproduced this against the live v0.9.0 assets:
codebase-memory-mcp-windows-amd64.zipentries:codebase-memory-mcp.exe,LICENSE,install.ps1,THIRD_PARTY_NOTICES.md(nocbm-integrations.json)codebase-memory-mcp-linux-amd64.tar.gzentries: same four-file core layoutSolution
cbm-integrations.json).scripts/package-release.shis unchanged and still shipscbm-integrations.jsonfor new builds.Verification
Also checked the live v0.9.0 member lists against the new acceptance matrix (legacy 4-file and current 5-file both pass; incomplete/extra/duplicate still fail).
Limitations
cbm-integrations.jsonis published, both layouts remain valid; new archives should keep shipping the integration manifest viapackage-release.sh.Checklist
scripts/test.sh/ ASan suite (not run — installer-only change)